Commit 97521978 authored by dyoung@redhat.com's avatar dyoung@redhat.com Committed by Greg Kroah-Hartman

driver core: print sysfs attribute name when warning about bogus permissions

Make it obvious to see what attribute is using bogus permissions.
Signed-off-by: default avatarDave Young <dyoung@redhat.com>
Acked-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1c04fc35
...@@ -572,9 +572,11 @@ int device_create_file(struct device *dev, ...@@ -572,9 +572,11 @@ int device_create_file(struct device *dev,
if (dev) { if (dev) {
WARN(((attr->attr.mode & S_IWUGO) && !attr->store), WARN(((attr->attr.mode & S_IWUGO) && !attr->store),
"Write permission without 'store'\n"); "Attribute %s: write permission without 'store'\n",
attr->attr.name);
WARN(((attr->attr.mode & S_IRUGO) && !attr->show), WARN(((attr->attr.mode & S_IRUGO) && !attr->show),
"Read permission without 'show'\n"); "Attribute %s: read permission without 'show'\n",
attr->attr.name);
error = sysfs_create_file(&dev->kobj, &attr->attr); error = sysfs_create_file(&dev->kobj, &attr->attr);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment