Commit 97a2f40e authored by Wei Yongjun's avatar Wei Yongjun Committed by Arnd Bergmann

bus: arm-integrator-lm: Fix return value check in integrator_ap_lm_probe()

In case of error, the function of_find_matching_node() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Link: https://lore.kernel.org/r/20200525091634.8274-1-linus.walleij@linaro.org
Fixes: ccea5e8a ("bus: Add driver for Integrator/AP logic modules")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200520032150.165388-1-weiyongjun1@huawei.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 9d281a4f
...@@ -78,10 +78,10 @@ static int integrator_ap_lm_probe(struct platform_device *pdev) ...@@ -78,10 +78,10 @@ static int integrator_ap_lm_probe(struct platform_device *pdev)
/* Look up the system controller */ /* Look up the system controller */
syscon = of_find_matching_node(NULL, integrator_ap_syscon_match); syscon = of_find_matching_node(NULL, integrator_ap_syscon_match);
if (IS_ERR(syscon)) { if (!syscon) {
dev_err(dev, dev_err(dev,
"could not find Integrator/AP system controller\n"); "could not find Integrator/AP system controller\n");
return PTR_ERR(syscon); return -ENODEV;
} }
map = syscon_node_to_regmap(syscon); map = syscon_node_to_regmap(syscon);
if (IS_ERR(map)) { if (IS_ERR(map)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment