Commit 97c93e06 authored by Tom Rix's avatar Tom Rix Committed by Wolfram Sang

i2c: amd_mp2: handle num is 0 input for i2c_amd_xfer

clang static analyzer reports this problem

i2c-amd-mp2-plat.c:174:9: warning: Branch condition evaluates
  to a garbage value
        return err ? err : num;
               ^~~

err is not initialized, it depends on the being set in the
transfer loop which will not happen if num is 0.  Surveying
other master_xfer() implementations show all handle a 0 num.

Because returning 0 is expected, initialize err to 0.
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Acked-by: default avatarElie Morisse <syniurge@gmail.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 703b3228
......@@ -155,7 +155,7 @@ static int i2c_amd_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
struct amd_i2c_dev *i2c_dev = i2c_get_adapdata(adap);
int i;
struct i2c_msg *pmsg;
int err;
int err = 0;
/* the adapter might have been deleted while waiting for the bus lock */
if (unlikely(!i2c_dev->common.mp2_dev))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment