Commit 97f5b037 authored by Dan Carpenter's avatar Dan Carpenter Committed by Alexandre Belloni

rtc: rv3029: Clean up error handling in rv3029_eeprom_write()

We don't need both "ret" and "err" when they do the same thing.  All the
functions called here return zero on success or negative error codes.
It's more clear to return a literal zero at the end instead of
"return ret;"
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 695e38d8
...@@ -282,13 +282,13 @@ static int rv3029_eeprom_read(struct device *dev, u8 reg, ...@@ -282,13 +282,13 @@ static int rv3029_eeprom_read(struct device *dev, u8 reg,
static int rv3029_eeprom_write(struct device *dev, u8 reg, static int rv3029_eeprom_write(struct device *dev, u8 reg,
u8 const buf[], size_t len) u8 const buf[], size_t len)
{ {
int ret, err; int ret;
size_t i; size_t i;
u8 tmp; u8 tmp;
err = rv3029_eeprom_enter(dev); ret = rv3029_eeprom_enter(dev);
if (err < 0) if (ret < 0)
return err; return ret;
for (i = 0; i < len; i++, reg++) { for (i = 0; i < len; i++, reg++) {
ret = rv3029_read_regs(dev, reg, &tmp, 1); ret = rv3029_read_regs(dev, reg, &tmp, 1);
...@@ -304,11 +304,11 @@ static int rv3029_eeprom_write(struct device *dev, u8 reg, ...@@ -304,11 +304,11 @@ static int rv3029_eeprom_write(struct device *dev, u8 reg,
break; break;
} }
err = rv3029_eeprom_exit(dev); ret = rv3029_eeprom_exit(dev);
if (err < 0) if (ret < 0)
return err; return ret;
return ret; return 0;
} }
static int rv3029_eeprom_update_bits(struct device *dev, static int rv3029_eeprom_update_bits(struct device *dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment