Commit 98486fa2 authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller

[BRIDGE]: Missing rtnl.

Writing to /sys/class/net/brX/bridge/stp_state causes a warning because
RTNL is not held when call br_stp_if.c
Signed-off-by: default avatarStephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c2886d62
...@@ -149,9 +149,11 @@ static ssize_t show_stp_state(struct device *d, ...@@ -149,9 +149,11 @@ static ssize_t show_stp_state(struct device *d,
static void set_stp_state(struct net_bridge *br, unsigned long val) static void set_stp_state(struct net_bridge *br, unsigned long val)
{ {
rtnl_lock();
spin_unlock_bh(&br->lock); spin_unlock_bh(&br->lock);
br_stp_set_enabled(br, val); br_stp_set_enabled(br, val);
spin_lock_bh(&br->lock); spin_lock_bh(&br->lock);
rtnl_unlock();
} }
static ssize_t store_stp_state(struct device *d, static ssize_t store_stp_state(struct device *d,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment