Commit 98b6d2b6 authored by simran singhal's avatar simran singhal Committed by Jonathan Cameron

iio: light: lm3533-als: constify attribute_group structures

Check for attribute_group structures that are only stored in the
event_attrs filed of iio_info structure. As the event_attrs field of
iio_info structures is constant, so these attribute_group structures can
also be declared constant. Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.event_attrs=&i@p;

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

As the attrs field of iio_info structures is also constant, so these
attribute_group structures can also be declared constant. Done manually.

File size before:
   text    data     bss     dec     hex filename
   5798    2376       0    8174    1fee drivers/iio/light/lm3533-als.o

File size after:
   text	   data	    bss	    dec	    hex	filename
   5926	   2248	      0	   8174	   1fee	drivers/iio/light/lm3533-als.o
Signed-off-by: default avatarsimran singhal <singhalsimran0@gmail.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 57380323
...@@ -690,7 +690,7 @@ static struct attribute *lm3533_als_event_attributes[] = { ...@@ -690,7 +690,7 @@ static struct attribute *lm3533_als_event_attributes[] = {
NULL NULL
}; };
static struct attribute_group lm3533_als_event_attribute_group = { static const struct attribute_group lm3533_als_event_attribute_group = {
.attrs = lm3533_als_event_attributes .attrs = lm3533_als_event_attributes
}; };
...@@ -714,7 +714,7 @@ static struct attribute *lm3533_als_attributes[] = { ...@@ -714,7 +714,7 @@ static struct attribute *lm3533_als_attributes[] = {
NULL NULL
}; };
static struct attribute_group lm3533_als_attribute_group = { static const struct attribute_group lm3533_als_attribute_group = {
.attrs = lm3533_als_attributes .attrs = lm3533_als_attributes
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment