Commit 99147e64 authored by Dan Carpenter's avatar Dan Carpenter Committed by Alex Deucher

drm/amd/powerplay: fix a couple locking issues

We should return unlock on the error path in pp_dpm_dispatch_tasks()
and there is a double lock bug in pp_dpm_set_sclk_od().

Fixes: 2a507105 ("drm/amd/powerplay: add global PowerPlay mutex.")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 0f987cd0
...@@ -493,8 +493,10 @@ static int pp_dpm_dispatch_tasks(void *handle, enum amd_pp_event event_id, ...@@ -493,8 +493,10 @@ static int pp_dpm_dispatch_tasks(void *handle, enum amd_pp_event event_id,
{ {
enum amd_pm_state_type ps; enum amd_pm_state_type ps;
if (input == NULL) if (input == NULL) {
return -EINVAL; ret = -EINVAL;
break;
}
ps = *(unsigned long *)input; ps = *(unsigned long *)input;
data.requested_ui_label = power_state_convert(ps); data.requested_ui_label = power_state_convert(ps);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment