Commit 99659a92 authored by Roel Kluin's avatar Roel Kluin Committed by H. Peter Anvin

x86, uv: Remove recursion in uv_heartbeat_enable()

The recursion is not needed and does not improve readability.
Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
LKML-Reference: <4B45F13E.3040202@gmail.com>
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
parent e1e0138d
...@@ -475,7 +475,7 @@ static void uv_heartbeat(unsigned long ignored) ...@@ -475,7 +475,7 @@ static void uv_heartbeat(unsigned long ignored)
static void __cpuinit uv_heartbeat_enable(int cpu) static void __cpuinit uv_heartbeat_enable(int cpu)
{ {
if (!uv_cpu_hub_info(cpu)->scir.enabled) { while (!uv_cpu_hub_info(cpu)->scir.enabled) {
struct timer_list *timer = &uv_cpu_hub_info(cpu)->scir.timer; struct timer_list *timer = &uv_cpu_hub_info(cpu)->scir.timer;
uv_set_cpu_scir_bits(cpu, SCIR_CPU_HEARTBEAT|SCIR_CPU_ACTIVITY); uv_set_cpu_scir_bits(cpu, SCIR_CPU_HEARTBEAT|SCIR_CPU_ACTIVITY);
...@@ -483,11 +483,10 @@ static void __cpuinit uv_heartbeat_enable(int cpu) ...@@ -483,11 +483,10 @@ static void __cpuinit uv_heartbeat_enable(int cpu)
timer->expires = jiffies + SCIR_CPU_HB_INTERVAL; timer->expires = jiffies + SCIR_CPU_HB_INTERVAL;
add_timer_on(timer, cpu); add_timer_on(timer, cpu);
uv_cpu_hub_info(cpu)->scir.enabled = 1; uv_cpu_hub_info(cpu)->scir.enabled = 1;
}
/* check boot cpu */ /* also ensure that boot cpu is enabled */
if (!uv_cpu_hub_info(0)->scir.enabled) cpu = 0;
uv_heartbeat_enable(0); }
} }
#ifdef CONFIG_HOTPLUG_CPU #ifdef CONFIG_HOTPLUG_CPU
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment