Commit 99d50b9b authored by Sudeep Holla's avatar Sudeep Holla

soc: realview: Use custom soc attribute group instead of device_create_file

Commit c31e7312 ("base: soc: Handle custom soc information sysfs
entries") introduced custom soc attribute group in soc_device_attribute
structure but there are no users treewide. While trying to understand
the motivation and tried to use it, it was found lot of existing custom
attributes can moved to use it instead of device_create_file.

Though most of these never remove/cleanup the custom attribute as they
never call soc_device_unregister, using these custom attribute group
eliminate the need for any cleanup as the driver infrastructure will
take care of that.

Let us remove device_create_file and start using the custom attribute
group in soc_device_attribute.

Link: https://lore.kernel.org/r/20200523170859.50003-3-sudeep.holla@arm.com
Cc: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 5feebc65
......@@ -71,6 +71,16 @@ build_show(struct device *dev, struct device_attribute *attr, char *buf)
static DEVICE_ATTR_RO(build);
static struct attribute *realview_attrs[] = {
&dev_attr_manufacturer.attr,
&dev_attr_board.attr,
&dev_attr_fpga.attr,
&dev_attr_build.attr,
NULL
};
ATTRIBUTE_GROUPS(realview);
static int realview_soc_probe(struct platform_device *pdev)
{
struct regmap *syscon_regmap;
......@@ -94,6 +104,7 @@ static int realview_soc_probe(struct platform_device *pdev)
soc_dev_attr->machine = "RealView";
soc_dev_attr->family = "Versatile";
soc_dev_attr->custom_attr_group = realview_groups[0];
soc_dev = soc_device_register(soc_dev_attr);
if (IS_ERR(soc_dev)) {
kfree(soc_dev_attr);
......@@ -104,11 +115,6 @@ static int realview_soc_probe(struct platform_device *pdev)
if (ret)
return -ENODEV;
device_create_file(soc_device_to_device(soc_dev), &dev_attr_manufacturer);
device_create_file(soc_device_to_device(soc_dev), &dev_attr_board);
device_create_file(soc_device_to_device(soc_dev), &dev_attr_fpga);
device_create_file(soc_device_to_device(soc_dev), &dev_attr_build);
dev_info(&pdev->dev, "RealView Syscon Core ID: 0x%08x, HBI-%03x\n",
realview_coreid,
((realview_coreid >> 16) & 0xfff));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment