Commit 9a5c034c authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini

KVM: x86/mmu: Skip invalid pages during zapping iff root_count is zero

Do not skip invalid shadow pages when zapping obsolete pages if the
pages' root_count has reached zero, in which case the page can be
immediately zapped and freed.

Update the comment accordingly.
Signed-off-by: default avatarSean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent ca333add
...@@ -5693,11 +5693,12 @@ static void kvm_zap_obsolete_pages(struct kvm *kvm) ...@@ -5693,11 +5693,12 @@ static void kvm_zap_obsolete_pages(struct kvm *kvm)
break; break;
/* /*
* Since we are reversely walking the list and the invalid * Skip invalid pages with a non-zero root count, zapping pages
* list will be moved to the head, skip the invalid page * with a non-zero root count will never succeed, i.e. the page
* can help us to avoid the infinity list walking. * will get thrown back on active_mmu_pages and we'll get stuck
* in an infinite loop.
*/ */
if (sp->role.invalid) if (sp->role.invalid && sp->root_count)
continue; continue;
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment