Commit 9aaa25df authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Mark Brown

spi: bcm2835: add a sentinel at the end of the lookup array

GPIOLIB expects the array of lookup entries to be terminated with an
empty member. We need to increase the size of the variable length array
in the lookup table by 1.

Fixes: 21f252cd ("spi: bcm2835: reduce the abuse of the GPIO API")
Reported-by: default avatarHans de Goede <hdegoede@redhat.com>
Closes: https://lore.kernel.org/lkml/29764d46-8d3d-9794-bbde-d7928a91cbb5@redhat.com/Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231004183906.97845-1-brgl@bgdev.plSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8a6b446d
......@@ -1299,7 +1299,7 @@ static int bcm2835_spi_setup(struct spi_device *spi)
* More on the problem that it addresses:
* https://www.spinics.net/lists/linux-gpio/msg36218.html
*/
lookup = kzalloc(struct_size(lookup, table, 1), GFP_KERNEL);
lookup = kzalloc(struct_size(lookup, table, 2), GFP_KERNEL);
if (!lookup) {
ret = -ENOMEM;
goto err_cleanup;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment