Commit 9adc440e authored by Yifeng Li's avatar Yifeng Li Committed by Greg Kroah-Hartman

fbdev: sm712fb: fix memory frequency by avoiding a switch/case fallthrough

commit 9dc20113 upstream.

A fallthrough in switch/case was introduced in f627caf5 ("fbdev:
sm712fb: fix crashes and garbled display during DPMS modesetting"),
due to my copy-paste error, which would cause the memory clock frequency
for SM720 to be programmed to SM712.

Since it only reprograms the clock to a different frequency, it's only
a benign issue without visible side-effect, so it also evaded Sudip
Mukherjee's code review and regression tests. scripts/checkpatch.pl
also failed to discover the issue, possibly due to nested switch
statements.

This issue was found by Stephen Rothwell by building linux-next with
-Wimplicit-fallthrough.
Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Fixes: f627caf5 ("fbdev: sm712fb: fix crashes and garbled display during DPMS modesetting")
Signed-off-by: default avatarYifeng Li <tomli@tomli.me>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 038ec2c1
...@@ -898,6 +898,7 @@ static int smtc_blank(int blank_mode, struct fb_info *info) ...@@ -898,6 +898,7 @@ static int smtc_blank(int blank_mode, struct fb_info *info)
case 0x712: case 0x712:
smtc_seqw(0x6a, 0x16); smtc_seqw(0x6a, 0x16);
smtc_seqw(0x6b, 0x02); smtc_seqw(0x6b, 0x02);
break;
case 0x720: case 0x720:
smtc_seqw(0x6a, 0x0d); smtc_seqw(0x6a, 0x0d);
smtc_seqw(0x6b, 0x02); smtc_seqw(0x6b, 0x02);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment