Commit 9b41b92b authored by Allen Hung's avatar Allen Hung Committed by Jean Delvare

dmi-id: don't free dev structure after calling device_register

dmi_dev is freed in error exit code but, according to the document
of device_register, it should never directly free device structure
after calling this function, even if it returned an error! Use
put_device() instead.
Signed-off-by: default avatarAllen Hung <allen_hung@dell.com>
Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
parent d71f0586
...@@ -229,14 +229,14 @@ static int __init dmi_id_init(void) ...@@ -229,14 +229,14 @@ static int __init dmi_id_init(void)
ret = device_register(dmi_dev); ret = device_register(dmi_dev);
if (ret) if (ret)
goto fail_free_dmi_dev; goto fail_put_dmi_dev;
return 0; return 0;
fail_free_dmi_dev: fail_put_dmi_dev:
kfree(dmi_dev); put_device(dmi_dev);
fail_class_unregister:
fail_class_unregister:
class_unregister(&dmi_class); class_unregister(&dmi_class);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment