Commit 9b72dbfe authored by Bart Van Assche's avatar Bart Van Assche Committed by Luis Henriques

tcm_qla2xxx: Fix incorrect use of __transport_register_session

commit 75c3d0bf upstream.

This patch fixes the incorrect use of __transport_register_session()
in tcm_qla2xxx_check_initiator_node_acl() code, that does not perform
explicit se_tpg->session_lock when accessing se_tpg->tpg_sess_list
to add new se_sess nodes.

Given that tcm_qla2xxx_check_initiator_node_acl() is not called with
qla_hw->hardware_lock held for all accesses of ->tpg_sess_list, the
code should be using transport_register_session() instead.
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Cc: Giridhar Malavali <giridhar.malavali@qlogic.com>
Cc: Quinn Tran <quinn.tran@qlogic.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 41e5c1d8
...@@ -1569,7 +1569,7 @@ static int tcm_qla2xxx_check_initiator_node_acl( ...@@ -1569,7 +1569,7 @@ static int tcm_qla2xxx_check_initiator_node_acl(
/* /*
* Finally register the new FC Nexus with TCM * Finally register the new FC Nexus with TCM
*/ */
__transport_register_session(se_nacl->se_tpg, se_nacl, se_sess, sess); transport_register_session(se_nacl->se_tpg, se_nacl, se_sess, sess);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment