Commit 9bbb3329 authored by Tom Zanussi's avatar Tom Zanussi Committed by Steven Rostedt (VMware)

tracing: Check that the synthetic event and field names are legal

Call the is_good_name() function used by probe events to make sure
synthetic event and field names don't contain illegal characters and
cause unexpected parsing of synthetic event commands.

Link: https://lkml.kernel.org/r/c4d4bb59d3ac39bcbd70fba0cf837d6b1cedb015.1602598160.git.zanussi@kernel.org

Fixes: 4b147936 (tracing: Add support for 'synthetic' events)
Reported-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
Reviewed-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
Tested-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: default avatarTom Zanussi <zanussi@kernel.org>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent 42d120e2
...@@ -572,6 +572,10 @@ static struct synth_field *parse_synth_field(int argc, const char **argv, ...@@ -572,6 +572,10 @@ static struct synth_field *parse_synth_field(int argc, const char **argv,
ret = -ENOMEM; ret = -ENOMEM;
goto free; goto free;
} }
if (!is_good_name(field->name)) {
ret = -EINVAL;
goto free;
}
if (field_type[0] == ';') if (field_type[0] == ';')
field_type++; field_type++;
...@@ -1112,6 +1116,11 @@ static int __create_synth_event(int argc, const char *name, const char **argv) ...@@ -1112,6 +1116,11 @@ static int __create_synth_event(int argc, const char *name, const char **argv)
mutex_lock(&event_mutex); mutex_lock(&event_mutex);
if (!is_good_name(name)) {
ret = -EINVAL;
goto out;
}
event = find_synth_event(name); event = find_synth_event(name);
if (event) { if (event) {
ret = -EEXIST; ret = -EEXIST;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment