Commit 9cbe67c5 authored by Chris Wilson's avatar Chris Wilson

drm/syncobj: Mark local add/remove callback functions as static

drivers/gpu/drm/drm_syncobj.c:181:6: warning: no previous prototype for ‘drm_syncobj_add_callback’ [-Wmissing-prototypes]
drivers/gpu/drm/drm_syncobj.c:190:6: warning: no previous prototype for ‘drm_syncobj_remove_callback’ [-Wmissing-prototypes]

Fixing that leads to

drivers/gpu/drm/drm_syncobj.c:181:13: warning: ‘drm_syncobj_add_callback’ defined but not used [-Wunused-function]

so remove the unused drm_syncobj_add_callback() entirely.
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20181031120710.21582-1-chris@chris-wilson.co.ukReviewed-by: default avatarChunming Zhou <david1.zhou@amd.com>
parent 03ceb1c8
...@@ -123,9 +123,9 @@ struct drm_syncobj *drm_syncobj_find(struct drm_file *file_private, ...@@ -123,9 +123,9 @@ struct drm_syncobj *drm_syncobj_find(struct drm_file *file_private,
} }
EXPORT_SYMBOL(drm_syncobj_find); EXPORT_SYMBOL(drm_syncobj_find);
static struct dma_fence static struct dma_fence *
*drm_syncobj_find_signal_pt_for_point(struct drm_syncobj *syncobj, drm_syncobj_find_signal_pt_for_point(struct drm_syncobj *syncobj,
uint64_t point) uint64_t point)
{ {
struct drm_syncobj_signal_pt *signal_pt; struct drm_syncobj_signal_pt *signal_pt;
...@@ -178,17 +178,8 @@ static void drm_syncobj_fence_get_or_add_callback(struct drm_syncobj *syncobj, ...@@ -178,17 +178,8 @@ static void drm_syncobj_fence_get_or_add_callback(struct drm_syncobj *syncobj,
mutex_unlock(&syncobj->cb_mutex); mutex_unlock(&syncobj->cb_mutex);
} }
void drm_syncobj_add_callback(struct drm_syncobj *syncobj, static void drm_syncobj_remove_callback(struct drm_syncobj *syncobj,
struct drm_syncobj_cb *cb, struct drm_syncobj_cb *cb)
drm_syncobj_func_t func)
{
mutex_lock(&syncobj->cb_mutex);
drm_syncobj_add_callback_locked(syncobj, cb, func);
mutex_unlock(&syncobj->cb_mutex);
}
void drm_syncobj_remove_callback(struct drm_syncobj *syncobj,
struct drm_syncobj_cb *cb)
{ {
mutex_lock(&syncobj->cb_mutex); mutex_lock(&syncobj->cb_mutex);
list_del_init(&cb->node); list_del_init(&cb->node);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment