Commit 9d1b3895 authored by Masahiro Yamada's avatar Masahiro Yamada

scripts/kallsyms: fix memory corruption caused by write over-run

memcpy() writes one more byte than allocated.

Fixes: 8d605269 ("scripts/kallsyms: change table to store (strcut sym_entry *)")
Reported-by: default avataryouling257 <youling257@gmail.com>
Reported-by: default avatarPavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Tested-by: default avatarPavel Machek <pavel@ucw.cz>
parent bb6d3fb3
...@@ -210,7 +210,7 @@ static struct sym_entry *read_symbol(FILE *in) ...@@ -210,7 +210,7 @@ static struct sym_entry *read_symbol(FILE *in)
len = strlen(name) + 1; len = strlen(name) + 1;
sym = malloc(sizeof(*sym) + len); sym = malloc(sizeof(*sym) + len + 1);
if (!sym) { if (!sym) {
fprintf(stderr, "kallsyms failure: " fprintf(stderr, "kallsyms failure: "
"unable to allocate required amount of memory\n"); "unable to allocate required amount of memory\n");
...@@ -219,7 +219,7 @@ static struct sym_entry *read_symbol(FILE *in) ...@@ -219,7 +219,7 @@ static struct sym_entry *read_symbol(FILE *in)
sym->addr = addr; sym->addr = addr;
sym->len = len; sym->len = len;
sym->sym[0] = type; sym->sym[0] = type;
memcpy(sym_name(sym), name, len); strcpy(sym_name(sym), name);
sym->percpu_absolute = 0; sym->percpu_absolute = 0;
return sym; return sym;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment