Commit 9d773f10 authored by Cai Huoqing's avatar Cai Huoqing Committed by Helge Deller

video: fbdev: omapfb: lcd_ams_delta: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 1d09b2a1
...@@ -131,18 +131,14 @@ static int ams_delta_panel_probe(struct platform_device *pdev) ...@@ -131,18 +131,14 @@ static int ams_delta_panel_probe(struct platform_device *pdev)
int ret; int ret;
gpiod_vblen = devm_gpiod_get(&pdev->dev, "vblen", GPIOD_OUT_LOW); gpiod_vblen = devm_gpiod_get(&pdev->dev, "vblen", GPIOD_OUT_LOW);
if (IS_ERR(gpiod_vblen)) { if (IS_ERR(gpiod_vblen))
ret = PTR_ERR(gpiod_vblen); return dev_err_probe(&pdev->dev, PTR_ERR(gpiod_vblen),
dev_err(&pdev->dev, "VBLEN GPIO request failed (%d)\n", ret); "VBLEN GPIO request failed\n");
return ret;
}
gpiod_ndisp = devm_gpiod_get(&pdev->dev, "ndisp", GPIOD_OUT_LOW); gpiod_ndisp = devm_gpiod_get(&pdev->dev, "ndisp", GPIOD_OUT_LOW);
if (IS_ERR(gpiod_ndisp)) { if (IS_ERR(gpiod_ndisp))
ret = PTR_ERR(gpiod_ndisp); return dev_err_probe(&pdev->dev, PTR_ERR(gpiod_ndisp),
dev_err(&pdev->dev, "NDISP GPIO request failed (%d)\n", ret); "NDISP GPIO request failed\n");
return ret;
}
#ifdef CONFIG_LCD_CLASS_DEVICE #ifdef CONFIG_LCD_CLASS_DEVICE
lcd_device = lcd_device_register("omapfb", &pdev->dev, NULL, lcd_device = lcd_device_register("omapfb", &pdev->dev, NULL,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment