Commit 9da29c7f authored by Christian König's avatar Christian König Committed by Linus Torvalds

coda: fix reference counting in coda_file_mmap error path

mmap_region() now calls fput() on the vma->vm_file.

So we need to drop the extra reference on the coda file instead of the
host file.

Link: https://lkml.kernel.org/r/20210421132012.82354-1-christian.koenig@amd.com
Fixes: 1527f926 ("mm: mmap: fix fput in error path v2")
Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: default avatarJan Harkes <jaharkes@cs.cmu.edu>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: <stable@vger.kernel.org>	[5.11+]
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5bfc75d9
...@@ -175,10 +175,10 @@ coda_file_mmap(struct file *coda_file, struct vm_area_struct *vma) ...@@ -175,10 +175,10 @@ coda_file_mmap(struct file *coda_file, struct vm_area_struct *vma)
ret = call_mmap(vma->vm_file, vma); ret = call_mmap(vma->vm_file, vma);
if (ret) { if (ret) {
/* if call_mmap fails, our caller will put coda_file so we /* if call_mmap fails, our caller will put host_file so we
* should drop the reference to the host_file that we got. * should drop the reference to the coda_file that we got.
*/ */
fput(host_file); fput(coda_file);
kfree(cvm_ops); kfree(cvm_ops);
} else { } else {
/* here we add redirects for the open/close vm_operations */ /* here we add redirects for the open/close vm_operations */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment