Commit 9dbb58d8 authored by Kurt Van Dijck's avatar Kurt Van Dijck Committed by David S. Miller

can: sja1000: fix bug using library functions for skb allocation

Commit 7b6856a0 "can: provide library functions for skb allocation"
did not properly remove two lines of the SJA1000 driver resulting in
a 'skb_over_panic' when calling skb_put, as reported by Kurt.
Signed-off-by: default avatarKurt Van Dijck <kurt.van.dijck@eia.be>
Signed-off-by: default avatarWolfgang Grandegger <wg@grandegger.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 10e85f7f
...@@ -321,8 +321,6 @@ static void sja1000_rx(struct net_device *dev) ...@@ -321,8 +321,6 @@ static void sja1000_rx(struct net_device *dev)
if (fi & FI_RTR) if (fi & FI_RTR)
id |= CAN_RTR_FLAG; id |= CAN_RTR_FLAG;
cf = (struct can_frame *)skb_put(skb, sizeof(struct can_frame));
memset(cf, 0, sizeof(struct can_frame));
cf->can_id = id; cf->can_id = id;
cf->can_dlc = dlc; cf->can_dlc = dlc;
for (i = 0; i < dlc; i++) for (i = 0; i < dlc; i++)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment