Commit 9ec4cbf1 authored by Hangyu Hua's avatar Hangyu Hua Committed by Greg Kroah-Hartman

usb: usbip: fix a refcount leak in stub_probe()

usb_get_dev() is called in stub_device_alloc(). When stub_probe() fails
after that, usb_put_dev() needs to be called to release the reference.

Fix this by moving usb_put_dev() to sdev_free error path handling.

Find this by code review.

Fixes: 3ff67445 ("usbip: fix error handling in stub_probe()")
Reviewed-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20220412020257.9767-1-hbh25y@gmail.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e8784c0a
...@@ -393,7 +393,6 @@ static int stub_probe(struct usb_device *udev) ...@@ -393,7 +393,6 @@ static int stub_probe(struct usb_device *udev)
err_port: err_port:
dev_set_drvdata(&udev->dev, NULL); dev_set_drvdata(&udev->dev, NULL);
usb_put_dev(udev);
/* we already have busid_priv, just lock busid_lock */ /* we already have busid_priv, just lock busid_lock */
spin_lock(&busid_priv->busid_lock); spin_lock(&busid_priv->busid_lock);
...@@ -408,6 +407,7 @@ static int stub_probe(struct usb_device *udev) ...@@ -408,6 +407,7 @@ static int stub_probe(struct usb_device *udev)
put_busid_priv(busid_priv); put_busid_priv(busid_priv);
sdev_free: sdev_free:
usb_put_dev(udev);
stub_device_free(sdev); stub_device_free(sdev);
return rc; return rc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment