Commit 9f3bdd4f authored by Axel Lin's avatar Axel Lin Committed by Rafael J. Wysocki

PM / devfreq: fix use after free in devfreq_remove_device

In devfreq_remove_device, calling _remove_devfreq will also free devfreq.
Don't dereference devfreq->governor->no_central_polling after _remove_devfreq.
Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarMyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
parent bc9f5449
...@@ -418,10 +418,14 @@ struct devfreq *devfreq_add_device(struct device *dev, ...@@ -418,10 +418,14 @@ struct devfreq *devfreq_add_device(struct device *dev,
*/ */
int devfreq_remove_device(struct devfreq *devfreq) int devfreq_remove_device(struct devfreq *devfreq)
{ {
bool central_polling;
if (!devfreq) if (!devfreq)
return -EINVAL; return -EINVAL;
if (!devfreq->governor->no_central_polling) { central_polling = !devfreq->governor->no_central_polling;
if (central_polling) {
mutex_lock(&devfreq_list_lock); mutex_lock(&devfreq_list_lock);
while (wait_remove_device == devfreq) { while (wait_remove_device == devfreq) {
mutex_unlock(&devfreq_list_lock); mutex_unlock(&devfreq_list_lock);
...@@ -433,7 +437,7 @@ int devfreq_remove_device(struct devfreq *devfreq) ...@@ -433,7 +437,7 @@ int devfreq_remove_device(struct devfreq *devfreq)
mutex_lock(&devfreq->lock); mutex_lock(&devfreq->lock);
_remove_devfreq(devfreq, false); /* it unlocks devfreq->lock */ _remove_devfreq(devfreq, false); /* it unlocks devfreq->lock */
if (!devfreq->governor->no_central_polling) if (central_polling)
mutex_unlock(&devfreq_list_lock); mutex_unlock(&devfreq_list_lock);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment