Skip to content

L
linux
Commit 9f91f22a authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Rob Clark
Browse files
Options

drm/msm/dsi: remove duplicate fields from dsi_pll_Nnm instances 

Drop duplicate fields pdev and id from dsi_pll_Nnm instances. Reuse
those fields from the provided msm_dsi_phy.
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarAbhinav Kumar <abhinavk@codeaurora.org>
Tested-by: Stephen Boyd <swboyd@chromium.org> # on sc7180 lazor
Link: https://lore.kernel.org/r/20210331105735.3690009-22-dmitry.baryshkov@linaro.orgSigned-off-by: default avatarRob Clark <robdclark@chromium.org>
parent b7cf8a54
Hide whitespace changes
Inline Side-by-side
Showing with 119 additions and 149 deletions
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c
View file @ 9f91f22a
...@@ -86,9 +86,6 @@ struct pll_10nm_cached_state { ...@@ -86,9 +86,6 @@ struct pll_10nm_cached_state {
struct dsi_pll_10nm { struct dsi_pll_10nm {
struct clk_hw clk_hw; struct clk_hw clk_hw;
int id;
struct platform_device *pdev;
struct msm_dsi_phy *phy; struct msm_dsi_phy *phy;
u64 vco_ref_clk_rate; u64 vco_ref_clk_rate;
...@@ -301,7 +298,7 @@ static int dsi_pll_10nm_vco_set_rate(struct clk_hw *hw, unsigned long rate, ...@@ -301,7 +298,7 @@ static int dsi_pll_10nm_vco_set_rate(struct clk_hw *hw, unsigned long rate,
{ {
struct dsi_pll_10nm *pll_10nm = to_pll_10nm(hw); struct dsi_pll_10nm *pll_10nm = to_pll_10nm(hw);
DBG("DSI PLL%d rate=%lu, parent's=%lu", pll_10nm->id, rate, DBG("DSI PLL%d rate=%lu, parent's=%lu", pll_10nm->phy->id, rate,
parent_rate); parent_rate);
pll_10nm->vco_current_rate = rate; pll_10nm->vco_current_rate = rate;
...@@ -327,7 +324,7 @@ static int dsi_pll_10nm_vco_set_rate(struct clk_hw *hw, unsigned long rate, ...@@ -327,7 +324,7 @@ static int dsi_pll_10nm_vco_set_rate(struct clk_hw *hw, unsigned long rate,
static int dsi_pll_10nm_lock_status(struct dsi_pll_10nm *pll) static int dsi_pll_10nm_lock_status(struct dsi_pll_10nm *pll)
{ {
struct device *dev = &pll->pdev->dev; struct device *dev = &pll->phy->pdev->dev;
int rc; int rc;
u32 status = 0; u32 status = 0;
u32 const delay_us = 100; u32 const delay_us = 100;
...@@ -341,7 +338,7 @@ static int dsi_pll_10nm_lock_status(struct dsi_pll_10nm *pll) ...@@ -341,7 +338,7 @@ static int dsi_pll_10nm_lock_status(struct dsi_pll_10nm *pll)
timeout_us); timeout_us);
if (rc) if (rc)
DRM_DEV_ERROR(dev, "DSI PLL(%d) lock failed, status=0x%08x\n", DRM_DEV_ERROR(dev, "DSI PLL(%d) lock failed, status=0x%08x\n",
pll->id, status); pll->phy->id, status);
return rc; return rc;
} }
...@@ -387,7 +384,7 @@ static void dsi_pll_enable_global_clk(struct dsi_pll_10nm *pll) ...@@ -387,7 +384,7 @@ static void dsi_pll_enable_global_clk(struct dsi_pll_10nm *pll)
static int dsi_pll_10nm_vco_prepare(struct clk_hw *hw) static int dsi_pll_10nm_vco_prepare(struct clk_hw *hw)
{ {
struct dsi_pll_10nm *pll_10nm = to_pll_10nm(hw); struct dsi_pll_10nm *pll_10nm = to_pll_10nm(hw);
struct device *dev = &pll_10nm->pdev->dev; struct device *dev = &pll_10nm->phy->pdev->dev;
int rc; int rc;
dsi_pll_enable_pll_bias(pll_10nm); dsi_pll_enable_pll_bias(pll_10nm);
...@@ -413,7 +410,7 @@ static int dsi_pll_10nm_vco_prepare(struct clk_hw *hw) ...@@ -413,7 +410,7 @@ static int dsi_pll_10nm_vco_prepare(struct clk_hw *hw)
/* Check for PLL lock */ /* Check for PLL lock */
rc = dsi_pll_10nm_lock_status(pll_10nm); rc = dsi_pll_10nm_lock_status(pll_10nm);
if (rc) { if (rc) {
DRM_DEV_ERROR(dev, "PLL(%d) lock failed\n", pll_10nm->id); DRM_DEV_ERROR(dev, "PLL(%d) lock failed\n", pll_10nm->phy->id);
goto error; goto error;
} }
...@@ -494,7 +491,7 @@ static unsigned long dsi_pll_10nm_vco_recalc_rate(struct clk_hw *hw, ...@@ -494,7 +491,7 @@ static unsigned long dsi_pll_10nm_vco_recalc_rate(struct clk_hw *hw,
vco_rate = pll_freq; vco_rate = pll_freq;
DBG("DSI PLL%d returning vco rate = %lu, dec = %x, frac = %x", DBG("DSI PLL%d returning vco rate = %lu, dec = %x, frac = %x",
pll_10nm->id, (unsigned long)vco_rate, dec, frac); pll_10nm->phy->id, (unsigned long)vco_rate, dec, frac);
return (unsigned long)vco_rate; return (unsigned long)vco_rate;
} }
...@@ -543,7 +540,7 @@ static void dsi_10nm_pll_save_state(struct msm_dsi_phy *phy) ...@@ -543,7 +540,7 @@ static void dsi_10nm_pll_save_state(struct msm_dsi_phy *phy)
cached->pll_mux = cmn_clk_cfg1 & 0x3; cached->pll_mux = cmn_clk_cfg1 & 0x3;
DBG("DSI PLL%d outdiv %x bit_clk_div %x pix_clk_div %x pll_mux %x", DBG("DSI PLL%d outdiv %x bit_clk_div %x pix_clk_div %x pll_mux %x",
pll_10nm->id, cached->pll_out_div, cached->bit_clk_div, pll_10nm->phy->id, cached->pll_out_div, cached->bit_clk_div,
cached->pix_clk_div, cached->pll_mux); cached->pix_clk_div, cached->pll_mux);
} }
...@@ -572,12 +569,12 @@ static int dsi_10nm_pll_restore_state(struct msm_dsi_phy *phy) ...@@ -572,12 +569,12 @@ static int dsi_10nm_pll_restore_state(struct msm_dsi_phy *phy)
pll_10nm->vco_current_rate, pll_10nm->vco_current_rate,
pll_10nm->vco_ref_clk_rate); pll_10nm->vco_ref_clk_rate);
if (ret) { if (ret) {
DRM_DEV_ERROR(&pll_10nm->pdev->dev, DRM_DEV_ERROR(&pll_10nm->phy->pdev->dev,
"restore vco rate failed. ret=%d\n", ret); "restore vco rate failed. ret=%d\n", ret);
return ret; return ret;
} }
DBG("DSI PLL%d", pll_10nm->id); DBG("DSI PLL%d", pll_10nm->phy->id);
return 0; return 0;
} }
...@@ -588,13 +585,13 @@ static int dsi_10nm_set_usecase(struct msm_dsi_phy *phy) ...@@ -588,13 +585,13 @@ static int dsi_10nm_set_usecase(struct msm_dsi_phy *phy)
void __iomem *base = phy->base; void __iomem *base = phy->base;
u32 data = 0x0; /* internal PLL */ u32 data = 0x0; /* internal PLL */
DBG("DSI PLL%d", pll_10nm->id); DBG("DSI PLL%d", pll_10nm->phy->id);
switch (phy->usecase) { switch (phy->usecase) {
case MSM_DSI_PHY_STANDALONE: case MSM_DSI_PHY_STANDALONE:
break; break;
case MSM_DSI_PHY_MASTER: case MSM_DSI_PHY_MASTER:
pll_10nm->slave = pll_10nm_list[(pll_10nm->id + 1) % DSI_MAX]; pll_10nm->slave = pll_10nm_list[(pll_10nm->phy->id + 1) % DSI_MAX];
break; break;
case MSM_DSI_PHY_SLAVE: case MSM_DSI_PHY_SLAVE:
data = 0x1; /* external PLL */ data = 0x1; /* external PLL */
...@@ -626,21 +623,21 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov ...@@ -626,21 +623,21 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov
.flags = CLK_IGNORE_UNUSED, .flags = CLK_IGNORE_UNUSED,
.ops = &clk_ops_dsi_pll_10nm_vco, .ops = &clk_ops_dsi_pll_10nm_vco,
}; };
struct device *dev = &pll_10nm->pdev->dev; struct device *dev = &pll_10nm->phy->pdev->dev;
struct clk_hw *hw; struct clk_hw *hw;
int ret; int ret;
DBG("DSI%d", pll_10nm->id); DBG("DSI%d", pll_10nm->phy->id);
snprintf(vco_name, 32, "dsi%dvco_clk", pll_10nm->id); snprintf(vco_name, 32, "dsi%dvco_clk", pll_10nm->phy->id);
pll_10nm->clk_hw.init = &vco_init; pll_10nm->clk_hw.init = &vco_init;
ret = devm_clk_hw_register(dev, &pll_10nm->clk_hw); ret = devm_clk_hw_register(dev, &pll_10nm->clk_hw);
if (ret) if (ret)
return ret; return ret;
snprintf(clk_name, 32, "dsi%d_pll_out_div_clk", pll_10nm->id); snprintf(clk_name, 32, "dsi%d_pll_out_div_clk", pll_10nm->phy->id);
snprintf(parent, 32, "dsi%dvco_clk", pll_10nm->id); snprintf(parent, 32, "dsi%dvco_clk", pll_10nm->phy->id);
hw = devm_clk_hw_register_divider(dev, clk_name, hw = devm_clk_hw_register_divider(dev, clk_name,
parent, CLK_SET_RATE_PARENT, parent, CLK_SET_RATE_PARENT,
...@@ -652,8 +649,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov ...@@ -652,8 +649,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov
goto fail; goto fail;
} }
snprintf(clk_name, 32, "dsi%d_pll_bit_clk", pll_10nm->id); snprintf(clk_name, 32, "dsi%d_pll_bit_clk", pll_10nm->phy->id);
snprintf(parent, 32, "dsi%d_pll_out_div_clk", pll_10nm->id); snprintf(parent, 32, "dsi%d_pll_out_div_clk", pll_10nm->phy->id);
/* BIT CLK: DIV_CTRL_3_0 */ /* BIT CLK: DIV_CTRL_3_0 */
hw = devm_clk_hw_register_divider(dev, clk_name, parent, hw = devm_clk_hw_register_divider(dev, clk_name, parent,
...@@ -667,8 +664,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov ...@@ -667,8 +664,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov
goto fail; goto fail;
} }
snprintf(clk_name, 32, "dsi%d_phy_pll_out_byteclk", pll_10nm->id); snprintf(clk_name, 32, "dsi%d_phy_pll_out_byteclk", pll_10nm->phy->id);
snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_10nm->id); snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_10nm->phy->id);
/* DSI Byte clock = VCO_CLK / OUT_DIV / BIT_DIV / 8 */ /* DSI Byte clock = VCO_CLK / OUT_DIV / BIT_DIV / 8 */
hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent, hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent,
...@@ -680,8 +677,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov ...@@ -680,8 +677,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov
provided_clocks[DSI_BYTE_PLL_CLK] = hw; provided_clocks[DSI_BYTE_PLL_CLK] = hw;
snprintf(clk_name, 32, "dsi%d_pll_by_2_bit_clk", pll_10nm->id); snprintf(clk_name, 32, "dsi%d_pll_by_2_bit_clk", pll_10nm->phy->id);
snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_10nm->id); snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_10nm->phy->id);
hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent, hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent,
0, 1, 2); 0, 1, 2);
...@@ -690,8 +687,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov ...@@ -690,8 +687,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov
goto fail; goto fail;
} }
snprintf(clk_name, 32, "dsi%d_pll_post_out_div_clk", pll_10nm->id); snprintf(clk_name, 32, "dsi%d_pll_post_out_div_clk", pll_10nm->phy->id);
snprintf(parent, 32, "dsi%d_pll_out_div_clk", pll_10nm->id); snprintf(parent, 32, "dsi%d_pll_out_div_clk", pll_10nm->phy->id);
hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent, hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent,
0, 1, 4); 0, 1, 4);
...@@ -700,11 +697,11 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov ...@@ -700,11 +697,11 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov
goto fail; goto fail;
} }
snprintf(clk_name, 32, "dsi%d_pclk_mux", pll_10nm->id); snprintf(clk_name, 32, "dsi%d_pclk_mux", pll_10nm->phy->id);
snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_10nm->id); snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_10nm->phy->id);
snprintf(parent2, 32, "dsi%d_pll_by_2_bit_clk", pll_10nm->id); snprintf(parent2, 32, "dsi%d_pll_by_2_bit_clk", pll_10nm->phy->id);
snprintf(parent3, 32, "dsi%d_pll_out_div_clk", pll_10nm->id); snprintf(parent3, 32, "dsi%d_pll_out_div_clk", pll_10nm->phy->id);
snprintf(parent4, 32, "dsi%d_pll_post_out_div_clk", pll_10nm->id); snprintf(parent4, 32, "dsi%d_pll_post_out_div_clk", pll_10nm->phy->id);
hw = devm_clk_hw_register_mux(dev, clk_name, hw = devm_clk_hw_register_mux(dev, clk_name,
((const char *[]){ ((const char *[]){
...@@ -717,8 +714,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov ...@@ -717,8 +714,8 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov
goto fail; goto fail;
} }
snprintf(clk_name, 32, "dsi%d_phy_pll_out_dsiclk", pll_10nm->id); snprintf(clk_name, 32, "dsi%d_phy_pll_out_dsiclk", pll_10nm->phy->id);
snprintf(parent, 32, "dsi%d_pclk_mux", pll_10nm->id); snprintf(parent, 32, "dsi%d_pclk_mux", pll_10nm->phy->id);
/* PIX CLK DIV : DIV_CTRL_7_4*/ /* PIX CLK DIV : DIV_CTRL_7_4*/
hw = devm_clk_hw_register_divider(dev, clk_name, parent, hw = devm_clk_hw_register_divider(dev, clk_name, parent,
...@@ -743,7 +740,6 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov ...@@ -743,7 +740,6 @@ static int pll_10nm_register(struct dsi_pll_10nm *pll_10nm, struct clk_hw **prov
static int dsi_pll_10nm_init(struct msm_dsi_phy *phy) static int dsi_pll_10nm_init(struct msm_dsi_phy *phy)
{ {
struct platform_device *pdev = phy->pdev; struct platform_device *pdev = phy->pdev;
int id = phy->id;
struct dsi_pll_10nm *pll_10nm; struct dsi_pll_10nm *pll_10nm;
int ret; int ret;
...@@ -751,11 +747,9 @@ static int dsi_pll_10nm_init(struct msm_dsi_phy *phy) ...@@ -751,11 +747,9 @@ static int dsi_pll_10nm_init(struct msm_dsi_phy *phy)
if (!pll_10nm) if (!pll_10nm)
return -ENOMEM; return -ENOMEM;
DBG("DSI PLL%d", id); DBG("DSI PLL%d", phy->id);
pll_10nm->pdev = pdev; pll_10nm_list[phy->id] = pll_10nm;
pll_10nm->id = id;
pll_10nm_list[id] = pll_10nm;
spin_lock_init(&pll_10nm->postdiv_lock); spin_lock_init(&pll_10nm->postdiv_lock);
......
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c
View file @ 9f91f22a
...@@ -115,9 +115,6 @@ struct pll_14nm_cached_state { ...@@ -115,9 +115,6 @@ struct pll_14nm_cached_state {
struct dsi_pll_14nm { struct dsi_pll_14nm {
struct clk_hw clk_hw; struct clk_hw clk_hw;
int id;
struct platform_device *pdev;
struct msm_dsi_phy *phy; struct msm_dsi_phy *phy;
struct dsi_pll_input in; struct dsi_pll_input in;
...@@ -498,7 +495,7 @@ static void pll_db_commit_14nm(struct dsi_pll_14nm *pll, ...@@ -498,7 +495,7 @@ static void pll_db_commit_14nm(struct dsi_pll_14nm *pll,
void __iomem *cmn_base = pll->phy->base; void __iomem *cmn_base = pll->phy->base;
u8 data; u8 data;
DBG("DSI%d PLL", pll->id); DBG("DSI%d PLL", pll->phy->id);
data = pout->cmn_ldo_cntrl; data = pout->cmn_ldo_cntrl;
dsi_phy_write(cmn_base + REG_DSI_14nm_PHY_CMN_LDO_CNTRL, data); dsi_phy_write(cmn_base + REG_DSI_14nm_PHY_CMN_LDO_CNTRL, data);
...@@ -565,7 +562,7 @@ static int dsi_pll_14nm_vco_set_rate(struct clk_hw *hw, unsigned long rate, ...@@ -565,7 +562,7 @@ static int dsi_pll_14nm_vco_set_rate(struct clk_hw *hw, unsigned long rate,
struct dsi_pll_input *pin = &pll_14nm->in; struct dsi_pll_input *pin = &pll_14nm->in;
struct dsi_pll_output *pout = &pll_14nm->out; struct dsi_pll_output *pout = &pll_14nm->out;
DBG("DSI PLL%d rate=%lu, parent's=%lu", pll_14nm->id, rate, DBG("DSI PLL%d rate=%lu, parent's=%lu", pll_14nm->phy->id, rate,
parent_rate); parent_rate);
pll_14nm->vco_current_rate = rate; pll_14nm->vco_current_rate = rate;
...@@ -666,7 +663,7 @@ static int dsi_pll_14nm_vco_prepare(struct clk_hw *hw) ...@@ -666,7 +663,7 @@ static int dsi_pll_14nm_vco_prepare(struct clk_hw *hw)
POLL_TIMEOUT_US); POLL_TIMEOUT_US);
if (unlikely(!locked)) { if (unlikely(!locked)) {
DRM_DEV_ERROR(&pll_14nm->pdev->dev, "DSI PLL lock failed\n"); DRM_DEV_ERROR(&pll_14nm->phy->pdev->dev, "DSI PLL lock failed\n");
return -EINVAL; return -EINVAL;
} }
...@@ -726,7 +723,7 @@ static unsigned long dsi_pll_14nm_postdiv_recalc_rate(struct clk_hw *hw, ...@@ -726,7 +723,7 @@ static unsigned long dsi_pll_14nm_postdiv_recalc_rate(struct clk_hw *hw,
u8 width = postdiv->width; u8 width = postdiv->width;
u32 val; u32 val;
DBG("DSI%d PLL parent rate=%lu", pll_14nm->id, parent_rate); DBG("DSI%d PLL parent rate=%lu", pll_14nm->phy->id, parent_rate);
val = dsi_phy_read(base + REG_DSI_14nm_PHY_CMN_CLK_CFG0) >> shift; val = dsi_phy_read(base + REG_DSI_14nm_PHY_CMN_CLK_CFG0) >> shift;
val &= div_mask(width); val &= div_mask(width);
...@@ -742,7 +739,7 @@ static long dsi_pll_14nm_postdiv_round_rate(struct clk_hw *hw, ...@@ -742,7 +739,7 @@ static long dsi_pll_14nm_postdiv_round_rate(struct clk_hw *hw,
struct dsi_pll_14nm_postdiv *postdiv = to_pll_14nm_postdiv(hw); struct dsi_pll_14nm_postdiv *postdiv = to_pll_14nm_postdiv(hw);
struct dsi_pll_14nm *pll_14nm = postdiv->pll; struct dsi_pll_14nm *pll_14nm = postdiv->pll;
DBG("DSI%d PLL parent rate=%lu", pll_14nm->id, rate); DBG("DSI%d PLL parent rate=%lu", pll_14nm->phy->id, rate);
return divider_round_rate(hw, rate, prate, NULL, return divider_round_rate(hw, rate, prate, NULL,
postdiv->width, postdiv->width,
...@@ -762,7 +759,7 @@ static int dsi_pll_14nm_postdiv_set_rate(struct clk_hw *hw, unsigned long rate, ...@@ -762,7 +759,7 @@ static int dsi_pll_14nm_postdiv_set_rate(struct clk_hw *hw, unsigned long rate,
unsigned long flags = 0; unsigned long flags = 0;
u32 val; u32 val;
DBG("DSI%d PLL parent rate=%lu parent rate %lu", pll_14nm->id, rate, DBG("DSI%d PLL parent rate=%lu parent rate %lu", pll_14nm->phy->id, rate,
parent_rate); parent_rate);
value = divider_get_val(rate, parent_rate, NULL, postdiv->width, value = divider_get_val(rate, parent_rate, NULL, postdiv->width,
...@@ -813,7 +810,7 @@ static void dsi_14nm_pll_save_state(struct msm_dsi_phy *phy) ...@@ -813,7 +810,7 @@ static void dsi_14nm_pll_save_state(struct msm_dsi_phy *phy)
cached_state->n1postdiv = data & 0xf; cached_state->n1postdiv = data & 0xf;
cached_state->n2postdiv = (data >> 4) & 0xf; cached_state->n2postdiv = (data >> 4) & 0xf;
DBG("DSI%d PLL save state %x %x", pll_14nm->id, DBG("DSI%d PLL save state %x %x", pll_14nm->phy->id,
cached_state->n1postdiv, cached_state->n2postdiv); cached_state->n1postdiv, cached_state->n2postdiv);
cached_state->vco_rate = clk_hw_get_rate(phy->vco_hw); cached_state->vco_rate = clk_hw_get_rate(phy->vco_hw);
...@@ -830,14 +827,14 @@ static int dsi_14nm_pll_restore_state(struct msm_dsi_phy *phy) ...@@ -830,14 +827,14 @@ static int dsi_14nm_pll_restore_state(struct msm_dsi_phy *phy)
ret = dsi_pll_14nm_vco_set_rate(phy->vco_hw, ret = dsi_pll_14nm_vco_set_rate(phy->vco_hw,
cached_state->vco_rate, 0); cached_state->vco_rate, 0);
if (ret) { if (ret) {
DRM_DEV_ERROR(&pll_14nm->pdev->dev, DRM_DEV_ERROR(&pll_14nm->phy->pdev->dev,
"restore vco rate failed. ret=%d\n", ret); "restore vco rate failed. ret=%d\n", ret);
return ret; return ret;
} }
data = cached_state->n1postdiv | (cached_state->n2postdiv << 4); data = cached_state->n1postdiv | (cached_state->n2postdiv << 4);
DBG("DSI%d PLL restore state %x %x", pll_14nm->id, DBG("DSI%d PLL restore state %x %x", pll_14nm->phy->id,
cached_state->n1postdiv, cached_state->n2postdiv); cached_state->n1postdiv, cached_state->n2postdiv);
dsi_phy_write(cmn_base + REG_DSI_14nm_PHY_CMN_CLK_CFG0, data); dsi_phy_write(cmn_base + REG_DSI_14nm_PHY_CMN_CLK_CFG0, data);
...@@ -865,7 +862,7 @@ static int dsi_14nm_set_usecase(struct msm_dsi_phy *phy) ...@@ -865,7 +862,7 @@ static int dsi_14nm_set_usecase(struct msm_dsi_phy *phy)
break; break;
case MSM_DSI_PHY_MASTER: case MSM_DSI_PHY_MASTER:
clkbuflr_en = 0x3; clkbuflr_en = 0x3;
pll_14nm->slave = pll_14nm_list[(pll_14nm->id + 1) % DSI_MAX]; pll_14nm->slave = pll_14nm_list[(pll_14nm->phy->id + 1) % DSI_MAX];
break; break;
case MSM_DSI_PHY_SLAVE: case MSM_DSI_PHY_SLAVE:
clkbuflr_en = 0x0; clkbuflr_en = 0x0;
...@@ -889,7 +886,7 @@ static struct clk_hw *pll_14nm_postdiv_register(struct dsi_pll_14nm *pll_14nm, ...@@ -889,7 +886,7 @@ static struct clk_hw *pll_14nm_postdiv_register(struct dsi_pll_14nm *pll_14nm,
u8 shift) u8 shift)
{ {
struct dsi_pll_14nm_postdiv *pll_postdiv; struct dsi_pll_14nm_postdiv *pll_postdiv;
struct device *dev = &pll_14nm->pdev->dev; struct device *dev = &pll_14nm->phy->pdev->dev;
struct clk_init_data postdiv_init = { struct clk_init_data postdiv_init = {
.parent_names = (const char *[]) { parent_name }, .parent_names = (const char *[]) { parent_name },
.num_parents = 1, .num_parents = 1,
...@@ -928,21 +925,21 @@ static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, struct clk_hw **prov ...@@ -928,21 +925,21 @@ static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, struct clk_hw **prov
.flags = CLK_IGNORE_UNUSED, .flags = CLK_IGNORE_UNUSED,
.ops = &clk_ops_dsi_pll_14nm_vco, .ops = &clk_ops_dsi_pll_14nm_vco,
}; };
struct device *dev = &pll_14nm->pdev->dev; struct device *dev = &pll_14nm->phy->pdev->dev;
struct clk_hw *hw; struct clk_hw *hw;
int ret; int ret;
DBG("DSI%d", pll_14nm->id); DBG("DSI%d", pll_14nm->phy->id);
snprintf(vco_name, 32, "dsi%dvco_clk", pll_14nm->id); snprintf(vco_name, 32, "dsi%dvco_clk", pll_14nm->phy->id);
pll_14nm->clk_hw.init = &vco_init; pll_14nm->clk_hw.init = &vco_init;
ret = devm_clk_hw_register(dev, &pll_14nm->clk_hw); ret = devm_clk_hw_register(dev, &pll_14nm->clk_hw);
if (ret) if (ret)
return ret; return ret;
snprintf(clk_name, 32, "dsi%dn1_postdiv_clk", pll_14nm->id); snprintf(clk_name, 32, "dsi%dn1_postdiv_clk", pll_14nm->phy->id);
snprintf(parent, 32, "dsi%dvco_clk", pll_14nm->id); snprintf(parent, 32, "dsi%dvco_clk", pll_14nm->phy->id);
/* N1 postdiv, bits 0-3 in REG_DSI_14nm_PHY_CMN_CLK_CFG0 */ /* N1 postdiv, bits 0-3 in REG_DSI_14nm_PHY_CMN_CLK_CFG0 */
hw = pll_14nm_postdiv_register(pll_14nm, clk_name, parent, hw = pll_14nm_postdiv_register(pll_14nm, clk_name, parent,
...@@ -950,8 +947,8 @@ static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, struct clk_hw **prov ...@@ -950,8 +947,8 @@ static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, struct clk_hw **prov
if (IS_ERR(hw)) if (IS_ERR(hw))
return PTR_ERR(hw); return PTR_ERR(hw);
snprintf(clk_name, 32, "dsi%dpllbyte", pll_14nm->id); snprintf(clk_name, 32, "dsi%dpllbyte", pll_14nm->phy->id);
snprintf(parent, 32, "dsi%dn1_postdiv_clk", pll_14nm->id); snprintf(parent, 32, "dsi%dn1_postdiv_clk", pll_14nm->phy->id);
/* DSI Byte clock = VCO_CLK / N1 / 8 */ /* DSI Byte clock = VCO_CLK / N1 / 8 */
hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent, hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent,
...@@ -961,8 +958,8 @@ static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, struct clk_hw **prov ...@@ -961,8 +958,8 @@ static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, struct clk_hw **prov
provided_clocks[DSI_BYTE_PLL_CLK] = hw; provided_clocks[DSI_BYTE_PLL_CLK] = hw;
snprintf(clk_name, 32, "dsi%dn1_postdivby2_clk", pll_14nm->id); snprintf(clk_name, 32, "dsi%dn1_postdivby2_clk", pll_14nm->phy->id);
snprintf(parent, 32, "dsi%dn1_postdiv_clk", pll_14nm->id); snprintf(parent, 32, "dsi%dn1_postdiv_clk", pll_14nm->phy->id);
/* /*
* Skip the mux for now, force DSICLK_SEL to 1, Add a /2 divider * Skip the mux for now, force DSICLK_SEL to 1, Add a /2 divider
...@@ -972,8 +969,8 @@ static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, struct clk_hw **prov ...@@ -972,8 +969,8 @@ static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, struct clk_hw **prov
if (IS_ERR(hw)) if (IS_ERR(hw))
return PTR_ERR(hw); return PTR_ERR(hw);
snprintf(clk_name, 32, "dsi%dpll", pll_14nm->id); snprintf(clk_name, 32, "dsi%dpll", pll_14nm->phy->id);
snprintf(parent, 32, "dsi%dn1_postdivby2_clk", pll_14nm->id); snprintf(parent, 32, "dsi%dn1_postdivby2_clk", pll_14nm->phy->id);
/* DSI pixel clock = VCO_CLK / N1 / 2 / N2 /* DSI pixel clock = VCO_CLK / N1 / 2 / N2
* This is the output of N2 post-divider, bits 4-7 in * This is the output of N2 post-divider, bits 4-7 in
...@@ -991,7 +988,6 @@ static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, struct clk_hw **prov ...@@ -991,7 +988,6 @@ static int pll_14nm_register(struct dsi_pll_14nm *pll_14nm, struct clk_hw **prov
static int dsi_pll_14nm_init(struct msm_dsi_phy *phy) static int dsi_pll_14nm_init(struct msm_dsi_phy *phy)
{ {
struct platform_device *pdev = phy->pdev; struct platform_device *pdev = phy->pdev;
int id = phy->id;
struct dsi_pll_14nm *pll_14nm; struct dsi_pll_14nm *pll_14nm;
int ret; int ret;
...@@ -1002,11 +998,9 @@ static int dsi_pll_14nm_init(struct msm_dsi_phy *phy) ...@@ -1002,11 +998,9 @@ static int dsi_pll_14nm_init(struct msm_dsi_phy *phy)
if (!pll_14nm) if (!pll_14nm)
return -ENOMEM; return -ENOMEM;
DBG("PLL%d", id); DBG("PLL%d", phy->id);
pll_14nm->pdev = pdev; pll_14nm_list[phy->id] = pll_14nm;
pll_14nm->id = id;
pll_14nm_list[id] = pll_14nm;
spin_lock_init(&pll_14nm->postdiv_lock); spin_lock_init(&pll_14nm->postdiv_lock);
......
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c
View file @ 9f91f22a
...@@ -67,9 +67,6 @@ struct pll_28nm_cached_state { ...@@ -67,9 +67,6 @@ struct pll_28nm_cached_state {
struct dsi_pll_28nm { struct dsi_pll_28nm {
struct clk_hw clk_hw; struct clk_hw clk_hw;
int id;
struct platform_device *pdev;
struct msm_dsi_phy *phy; struct msm_dsi_phy *phy;
struct pll_28nm_cached_state cached_state; struct pll_28nm_cached_state cached_state;
...@@ -117,7 +114,7 @@ static int dsi_pll_28nm_clk_set_rate(struct clk_hw *hw, unsigned long rate, ...@@ -117,7 +114,7 @@ static int dsi_pll_28nm_clk_set_rate(struct clk_hw *hw, unsigned long rate,
unsigned long parent_rate) unsigned long parent_rate)
{ {
struct dsi_pll_28nm *pll_28nm = to_pll_28nm(hw); struct dsi_pll_28nm *pll_28nm = to_pll_28nm(hw);
struct device *dev = &pll_28nm->pdev->dev; struct device *dev = &pll_28nm->phy->pdev->dev;
void __iomem *base = pll_28nm->phy->pll_base; void __iomem *base = pll_28nm->phy->pll_base;
unsigned long div_fbx1000, gen_vco_clk; unsigned long div_fbx1000, gen_vco_clk;
u32 refclk_cfg, frac_n_mode, frac_n_value; u32 refclk_cfg, frac_n_mode, frac_n_value;
...@@ -288,14 +285,14 @@ static unsigned long dsi_pll_28nm_clk_recalc_rate(struct clk_hw *hw, ...@@ -288,14 +285,14 @@ static unsigned long dsi_pll_28nm_clk_recalc_rate(struct clk_hw *hw,
static int _dsi_pll_28nm_vco_prepare_hpm(struct dsi_pll_28nm *pll_28nm) static int _dsi_pll_28nm_vco_prepare_hpm(struct dsi_pll_28nm *pll_28nm)
{ {
struct device *dev = &pll_28nm->pdev->dev; struct device *dev = &pll_28nm->phy->pdev->dev;
void __iomem *base = pll_28nm->phy->pll_base; void __iomem *base = pll_28nm->phy->pll_base;
u32 max_reads = 5, timeout_us = 100; u32 max_reads = 5, timeout_us = 100;
bool locked; bool locked;
u32 val; u32 val;
int i; int i;
DBG("id=%d", pll_28nm->id); DBG("id=%d", pll_28nm->phy->id);
pll_28nm_software_reset(pll_28nm); pll_28nm_software_reset(pll_28nm);
...@@ -382,13 +379,13 @@ static int dsi_pll_28nm_vco_prepare_hpm(struct clk_hw *hw) ...@@ -382,13 +379,13 @@ static int dsi_pll_28nm_vco_prepare_hpm(struct clk_hw *hw)
static int dsi_pll_28nm_vco_prepare_lp(struct clk_hw *hw) static int dsi_pll_28nm_vco_prepare_lp(struct clk_hw *hw)
{ {
struct dsi_pll_28nm *pll_28nm = to_pll_28nm(hw); struct dsi_pll_28nm *pll_28nm = to_pll_28nm(hw);
struct device *dev = &pll_28nm->pdev->dev; struct device *dev = &pll_28nm->phy->pdev->dev;
void __iomem *base = pll_28nm->phy->pll_base; void __iomem *base = pll_28nm->phy->pll_base;
bool locked; bool locked;
u32 max_reads = 10, timeout_us = 50; u32 max_reads = 10, timeout_us = 50;
u32 val; u32 val;
DBG("id=%d", pll_28nm->id); DBG("id=%d", pll_28nm->phy->id);
if (unlikely(pll_28nm->phy->pll_on)) if (unlikely(pll_28nm->phy->pll_on))
return 0; return 0;
...@@ -432,7 +429,7 @@ static void dsi_pll_28nm_vco_unprepare(struct clk_hw *hw) ...@@ -432,7 +429,7 @@ static void dsi_pll_28nm_vco_unprepare(struct clk_hw *hw)
{ {
struct dsi_pll_28nm *pll_28nm = to_pll_28nm(hw); struct dsi_pll_28nm *pll_28nm = to_pll_28nm(hw);
DBG("id=%d", pll_28nm->id); DBG("id=%d", pll_28nm->phy->id);
if (unlikely(!pll_28nm->phy->pll_on)) if (unlikely(!pll_28nm->phy->pll_on))
return; return;
...@@ -504,7 +501,7 @@ static int dsi_28nm_pll_restore_state(struct msm_dsi_phy *phy) ...@@ -504,7 +501,7 @@ static int dsi_28nm_pll_restore_state(struct msm_dsi_phy *phy)
ret = dsi_pll_28nm_clk_set_rate(phy->vco_hw, ret = dsi_pll_28nm_clk_set_rate(phy->vco_hw,
cached_state->vco_rate, 0); cached_state->vco_rate, 0);
if (ret) { if (ret) {
DRM_DEV_ERROR(&pll_28nm->pdev->dev, DRM_DEV_ERROR(&pll_28nm->phy->pdev->dev,
"restore vco rate failed. ret=%d\n", ret); "restore vco rate failed. ret=%d\n", ret);
return ret; return ret;
} }
...@@ -528,25 +525,25 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov ...@@ -528,25 +525,25 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
.name = vco_name, .name = vco_name,
.flags = CLK_IGNORE_UNUSED, .flags = CLK_IGNORE_UNUSED,
}; };
struct device *dev = &pll_28nm->pdev->dev; struct device *dev = &pll_28nm->phy->pdev->dev;
struct clk_hw *hw; struct clk_hw *hw;
int ret; int ret;
DBG("%d", pll_28nm->id); DBG("%d", pll_28nm->phy->id);
if (pll_28nm->phy->cfg->quirks & DSI_PHY_28NM_QUIRK_PHY_LP) if (pll_28nm->phy->cfg->quirks & DSI_PHY_28NM_QUIRK_PHY_LP)
vco_init.ops = &clk_ops_dsi_pll_28nm_vco_lp; vco_init.ops = &clk_ops_dsi_pll_28nm_vco_lp;
else else
vco_init.ops = &clk_ops_dsi_pll_28nm_vco_hpm; vco_init.ops = &clk_ops_dsi_pll_28nm_vco_hpm;
snprintf(vco_name, 32, "dsi%dvco_clk", pll_28nm->id); snprintf(vco_name, 32, "dsi%dvco_clk", pll_28nm->phy->id);
pll_28nm->clk_hw.init = &vco_init; pll_28nm->clk_hw.init = &vco_init;
ret = devm_clk_hw_register(dev, &pll_28nm->clk_hw); ret = devm_clk_hw_register(dev, &pll_28nm->clk_hw);
if (ret) if (ret)
return ret; return ret;
snprintf(clk_name, 32, "dsi%danalog_postdiv_clk", pll_28nm->id); snprintf(clk_name, 32, "dsi%danalog_postdiv_clk", pll_28nm->phy->id);
snprintf(parent1, 32, "dsi%dvco_clk", pll_28nm->id); snprintf(parent1, 32, "dsi%dvco_clk", pll_28nm->phy->id);
hw = devm_clk_hw_register_divider(dev, clk_name, hw = devm_clk_hw_register_divider(dev, clk_name,
parent1, CLK_SET_RATE_PARENT, parent1, CLK_SET_RATE_PARENT,
pll_28nm->phy->pll_base + pll_28nm->phy->pll_base +
...@@ -555,16 +552,16 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov ...@@ -555,16 +552,16 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
if (IS_ERR(hw)) if (IS_ERR(hw))
return PTR_ERR(hw); return PTR_ERR(hw);
snprintf(clk_name, 32, "dsi%dindirect_path_div2_clk", pll_28nm->id); snprintf(clk_name, 32, "dsi%dindirect_path_div2_clk", pll_28nm->phy->id);
snprintf(parent1, 32, "dsi%danalog_postdiv_clk", pll_28nm->id); snprintf(parent1, 32, "dsi%danalog_postdiv_clk", pll_28nm->phy->id);
hw = devm_clk_hw_register_fixed_factor(dev, clk_name, hw = devm_clk_hw_register_fixed_factor(dev, clk_name,
parent1, CLK_SET_RATE_PARENT, parent1, CLK_SET_RATE_PARENT,
1, 2); 1, 2);
if (IS_ERR(hw)) if (IS_ERR(hw))
return PTR_ERR(hw); return PTR_ERR(hw);
snprintf(clk_name, 32, "dsi%dpll", pll_28nm->id); snprintf(clk_name, 32, "dsi%dpll", pll_28nm->phy->id);
snprintf(parent1, 32, "dsi%dvco_clk", pll_28nm->id); snprintf(parent1, 32, "dsi%dvco_clk", pll_28nm->phy->id);
hw = devm_clk_hw_register_divider(dev, clk_name, hw = devm_clk_hw_register_divider(dev, clk_name,
parent1, 0, pll_28nm->phy->pll_base + parent1, 0, pll_28nm->phy->pll_base +
REG_DSI_28nm_PHY_PLL_POSTDIV3_CFG, REG_DSI_28nm_PHY_PLL_POSTDIV3_CFG,
...@@ -573,9 +570,9 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov ...@@ -573,9 +570,9 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
return PTR_ERR(hw); return PTR_ERR(hw);
provided_clocks[DSI_PIXEL_PLL_CLK] = hw; provided_clocks[DSI_PIXEL_PLL_CLK] = hw;
snprintf(clk_name, 32, "dsi%dbyte_mux", pll_28nm->id); snprintf(clk_name, 32, "dsi%dbyte_mux", pll_28nm->phy->id);
snprintf(parent1, 32, "dsi%dvco_clk", pll_28nm->id); snprintf(parent1, 32, "dsi%dvco_clk", pll_28nm->phy->id);
snprintf(parent2, 32, "dsi%dindirect_path_div2_clk", pll_28nm->id); snprintf(parent2, 32, "dsi%dindirect_path_div2_clk", pll_28nm->phy->id);
hw = devm_clk_hw_register_mux(dev, clk_name, hw = devm_clk_hw_register_mux(dev, clk_name,
((const char *[]){ ((const char *[]){
parent1, parent2 parent1, parent2
...@@ -584,8 +581,8 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov ...@@ -584,8 +581,8 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
if (IS_ERR(hw)) if (IS_ERR(hw))
return PTR_ERR(hw); return PTR_ERR(hw);
snprintf(clk_name, 32, "dsi%dpllbyte", pll_28nm->id); snprintf(clk_name, 32, "dsi%dpllbyte", pll_28nm->phy->id);
snprintf(parent1, 32, "dsi%dbyte_mux", pll_28nm->id); snprintf(parent1, 32, "dsi%dbyte_mux", pll_28nm->phy->id);
hw = devm_clk_hw_register_fixed_factor(dev, clk_name, hw = devm_clk_hw_register_fixed_factor(dev, clk_name,
parent1, CLK_SET_RATE_PARENT, 1, 4); parent1, CLK_SET_RATE_PARENT, 1, 4);
if (IS_ERR(hw)) if (IS_ERR(hw))
...@@ -598,7 +595,6 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov ...@@ -598,7 +595,6 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
static int dsi_pll_28nm_init(struct msm_dsi_phy *phy) static int dsi_pll_28nm_init(struct msm_dsi_phy *phy)
{ {
struct platform_device *pdev = phy->pdev; struct platform_device *pdev = phy->pdev;
int id = phy->id;
struct dsi_pll_28nm *pll_28nm; struct dsi_pll_28nm *pll_28nm;
int ret; int ret;
...@@ -609,8 +605,6 @@ static int dsi_pll_28nm_init(struct msm_dsi_phy *phy) ...@@ -609,8 +605,6 @@ static int dsi_pll_28nm_init(struct msm_dsi_phy *phy)
if (!pll_28nm) if (!pll_28nm)
return -ENOMEM; return -ENOMEM;
pll_28nm->pdev = pdev;
pll_28nm->id = id;
pll_28nm->phy = phy; pll_28nm->phy = phy;
ret = pll_28nm_register(pll_28nm, phy->provided_clocks->hws); ret = pll_28nm_register(pll_28nm, phy->provided_clocks->hws);
......
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c
View file @ 9f91f22a
...@@ -59,9 +59,6 @@ struct clk_bytediv { ...@@ -59,9 +59,6 @@ struct clk_bytediv {
struct dsi_pll_28nm { struct dsi_pll_28nm {
struct clk_hw clk_hw; struct clk_hw clk_hw;
int id;
struct platform_device *pdev;
struct msm_dsi_phy *phy; struct msm_dsi_phy *phy;
struct pll_28nm_cached_state cached_state; struct pll_28nm_cached_state cached_state;
...@@ -178,14 +175,14 @@ static unsigned long dsi_pll_28nm_clk_recalc_rate(struct clk_hw *hw, ...@@ -178,14 +175,14 @@ static unsigned long dsi_pll_28nm_clk_recalc_rate(struct clk_hw *hw,
static int dsi_pll_28nm_vco_prepare(struct clk_hw *hw) static int dsi_pll_28nm_vco_prepare(struct clk_hw *hw)
{ {
struct dsi_pll_28nm *pll_28nm = to_pll_28nm(hw); struct dsi_pll_28nm *pll_28nm = to_pll_28nm(hw);
struct device *dev = &pll_28nm->pdev->dev; struct device *dev = &pll_28nm->phy->pdev->dev;
void __iomem *base = pll_28nm->phy->pll_base; void __iomem *base = pll_28nm->phy->pll_base;
bool locked; bool locked;
unsigned int bit_div, byte_div; unsigned int bit_div, byte_div;
int max_reads = 1000, timeout_us = 100; int max_reads = 1000, timeout_us = 100;
u32 val; u32 val;
DBG("id=%d", pll_28nm->id); DBG("id=%d", pll_28nm->phy->id);
if (unlikely(pll_28nm->phy->pll_on)) if (unlikely(pll_28nm->phy->pll_on))
return 0; return 0;
...@@ -227,7 +224,7 @@ static void dsi_pll_28nm_vco_unprepare(struct clk_hw *hw) ...@@ -227,7 +224,7 @@ static void dsi_pll_28nm_vco_unprepare(struct clk_hw *hw)
{ {
struct dsi_pll_28nm *pll_28nm = to_pll_28nm(hw); struct dsi_pll_28nm *pll_28nm = to_pll_28nm(hw);
DBG("id=%d", pll_28nm->id); DBG("id=%d", pll_28nm->phy->id);
if (unlikely(!pll_28nm->phy->pll_on)) if (unlikely(!pll_28nm->phy->pll_on))
return; return;
...@@ -368,7 +365,7 @@ static int dsi_28nm_pll_restore_state(struct msm_dsi_phy *phy) ...@@ -368,7 +365,7 @@ static int dsi_28nm_pll_restore_state(struct msm_dsi_phy *phy)
ret = dsi_pll_28nm_clk_set_rate(phy->vco_hw, ret = dsi_pll_28nm_clk_set_rate(phy->vco_hw,
cached_state->vco_rate, 0); cached_state->vco_rate, 0);
if (ret) { if (ret) {
DRM_DEV_ERROR(&pll_28nm->pdev->dev, DRM_DEV_ERROR(&pll_28nm->phy->pdev->dev,
"restore vco rate failed. ret=%d\n", ret); "restore vco rate failed. ret=%d\n", ret);
return ret; return ret;
} }
...@@ -392,13 +389,13 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov ...@@ -392,13 +389,13 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
.flags = CLK_IGNORE_UNUSED, .flags = CLK_IGNORE_UNUSED,
.ops = &clk_ops_dsi_pll_28nm_vco, .ops = &clk_ops_dsi_pll_28nm_vco,
}; };
struct device *dev = &pll_28nm->pdev->dev; struct device *dev = &pll_28nm->phy->pdev->dev;
struct clk_hw *hw; struct clk_hw *hw;
struct clk_bytediv *bytediv; struct clk_bytediv *bytediv;
struct clk_init_data bytediv_init = { }; struct clk_init_data bytediv_init = { };
int ret; int ret;
DBG("%d", pll_28nm->id); DBG("%d", pll_28nm->phy->id);
bytediv = devm_kzalloc(dev, sizeof(*bytediv), GFP_KERNEL); bytediv = devm_kzalloc(dev, sizeof(*bytediv), GFP_KERNEL);
if (!bytediv) if (!bytediv)
...@@ -412,7 +409,7 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov ...@@ -412,7 +409,7 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
if (!clk_name) if (!clk_name)
return -ENOMEM; return -ENOMEM;
snprintf(vco_name, 32, "dsi%dvco_clk", pll_28nm->id); snprintf(vco_name, 32, "dsi%dvco_clk", pll_28nm->phy->id);
vco_init.name = vco_name; vco_init.name = vco_name;
pll_28nm->clk_hw.init = &vco_init; pll_28nm->clk_hw.init = &vco_init;
...@@ -425,8 +422,8 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov ...@@ -425,8 +422,8 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
bytediv->hw.init = &bytediv_init; bytediv->hw.init = &bytediv_init;
bytediv->reg = pll_28nm->phy->pll_base + REG_DSI_28nm_8960_PHY_PLL_CTRL_9; bytediv->reg = pll_28nm->phy->pll_base + REG_DSI_28nm_8960_PHY_PLL_CTRL_9;
snprintf(parent_name, 32, "dsi%dvco_clk", pll_28nm->id); snprintf(parent_name, 32, "dsi%dvco_clk", pll_28nm->phy->id);
snprintf(clk_name, 32, "dsi%dpllbyte", pll_28nm->id); snprintf(clk_name, 32, "dsi%dpllbyte", pll_28nm->phy->id);
bytediv_init.name = clk_name; bytediv_init.name = clk_name;
bytediv_init.ops = &clk_bytediv_ops; bytediv_init.ops = &clk_bytediv_ops;
...@@ -440,7 +437,7 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov ...@@ -440,7 +437,7 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
return ret; return ret;
provided_clocks[DSI_BYTE_PLL_CLK] = &bytediv->hw; provided_clocks[DSI_BYTE_PLL_CLK] = &bytediv->hw;
snprintf(clk_name, 32, "dsi%dpll", pll_28nm->id); snprintf(clk_name, 32, "dsi%dpll", pll_28nm->phy->id);
/* DIV3 */ /* DIV3 */
hw = devm_clk_hw_register_divider(dev, clk_name, hw = devm_clk_hw_register_divider(dev, clk_name,
parent_name, 0, pll_28nm->phy->pll_base + parent_name, 0, pll_28nm->phy->pll_base +
...@@ -456,7 +453,6 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov ...@@ -456,7 +453,6 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
static int dsi_pll_28nm_8960_init(struct msm_dsi_phy *phy) static int dsi_pll_28nm_8960_init(struct msm_dsi_phy *phy)
{ {
struct platform_device *pdev = phy->pdev; struct platform_device *pdev = phy->pdev;
int id = phy->id;
struct dsi_pll_28nm *pll_28nm; struct dsi_pll_28nm *pll_28nm;
int ret; int ret;
...@@ -467,8 +463,6 @@ static int dsi_pll_28nm_8960_init(struct msm_dsi_phy *phy) ...@@ -467,8 +463,6 @@ static int dsi_pll_28nm_8960_init(struct msm_dsi_phy *phy)
if (!pll_28nm) if (!pll_28nm)
return -ENOMEM; return -ENOMEM;
pll_28nm->pdev = pdev;
pll_28nm->id = id + 1;
pll_28nm->phy = phy; pll_28nm->phy = phy;
ret = pll_28nm_register(pll_28nm, phy->provided_clocks->hws); ret = pll_28nm_register(pll_28nm, phy->provided_clocks->hws);
......
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
View file @ 9f91f22a
...@@ -86,9 +86,6 @@ struct pll_7nm_cached_state { ...@@ -86,9 +86,6 @@ struct pll_7nm_cached_state {
struct dsi_pll_7nm { struct dsi_pll_7nm {
struct clk_hw clk_hw; struct clk_hw clk_hw;
int id;
struct platform_device *pdev;
struct msm_dsi_phy *phy; struct msm_dsi_phy *phy;
u64 vco_ref_clk_rate; u64 vco_ref_clk_rate;
...@@ -320,7 +317,7 @@ static int dsi_pll_7nm_vco_set_rate(struct clk_hw *hw, unsigned long rate, ...@@ -320,7 +317,7 @@ static int dsi_pll_7nm_vco_set_rate(struct clk_hw *hw, unsigned long rate,
{ {
struct dsi_pll_7nm *pll_7nm = to_pll_7nm(hw); struct dsi_pll_7nm *pll_7nm = to_pll_7nm(hw);
DBG("DSI PLL%d rate=%lu, parent's=%lu", pll_7nm->id, rate, DBG("DSI PLL%d rate=%lu, parent's=%lu", pll_7nm->phy->id, rate,
parent_rate); parent_rate);
pll_7nm->vco_current_rate = rate; pll_7nm->vco_current_rate = rate;
...@@ -359,7 +356,7 @@ static int dsi_pll_7nm_lock_status(struct dsi_pll_7nm *pll) ...@@ -359,7 +356,7 @@ static int dsi_pll_7nm_lock_status(struct dsi_pll_7nm *pll)
timeout_us); timeout_us);
if (rc) if (rc)
pr_err("DSI PLL(%d) lock failed, status=0x%08x\n", pr_err("DSI PLL(%d) lock failed, status=0x%08x\n",
pll->id, status); pll->phy->id, status);
return rc; return rc;
} }
...@@ -435,7 +432,7 @@ static int dsi_pll_7nm_vco_prepare(struct clk_hw *hw) ...@@ -435,7 +432,7 @@ static int dsi_pll_7nm_vco_prepare(struct clk_hw *hw)
/* Check for PLL lock */ /* Check for PLL lock */
rc = dsi_pll_7nm_lock_status(pll_7nm); rc = dsi_pll_7nm_lock_status(pll_7nm);
if (rc) { if (rc) {
pr_err("PLL(%d) lock failed\n", pll_7nm->id); pr_err("PLL(%d) lock failed\n", pll_7nm->phy->id);
goto error; goto error;
} }
...@@ -519,7 +516,7 @@ static unsigned long dsi_pll_7nm_vco_recalc_rate(struct clk_hw *hw, ...@@ -519,7 +516,7 @@ static unsigned long dsi_pll_7nm_vco_recalc_rate(struct clk_hw *hw,
vco_rate = pll_freq; vco_rate = pll_freq;
DBG("DSI PLL%d returning vco rate = %lu, dec = %x, frac = %x", DBG("DSI PLL%d returning vco rate = %lu, dec = %x, frac = %x",
pll_7nm->id, (unsigned long)vco_rate, dec, frac); pll_7nm->phy->id, (unsigned long)vco_rate, dec, frac);
return (unsigned long)vco_rate; return (unsigned long)vco_rate;
} }
...@@ -568,7 +565,7 @@ static void dsi_7nm_pll_save_state(struct msm_dsi_phy *phy) ...@@ -568,7 +565,7 @@ static void dsi_7nm_pll_save_state(struct msm_dsi_phy *phy)
cached->pll_mux = cmn_clk_cfg1 & 0x3; cached->pll_mux = cmn_clk_cfg1 & 0x3;
DBG("DSI PLL%d outdiv %x bit_clk_div %x pix_clk_div %x pll_mux %x", DBG("DSI PLL%d outdiv %x bit_clk_div %x pix_clk_div %x pll_mux %x",
pll_7nm->id, cached->pll_out_div, cached->bit_clk_div, pll_7nm->phy->id, cached->pll_out_div, cached->bit_clk_div,
cached->pix_clk_div, cached->pll_mux); cached->pix_clk_div, cached->pll_mux);
} }
...@@ -597,12 +594,12 @@ static int dsi_7nm_pll_restore_state(struct msm_dsi_phy *phy) ...@@ -597,12 +594,12 @@ static int dsi_7nm_pll_restore_state(struct msm_dsi_phy *phy)
pll_7nm->vco_current_rate, pll_7nm->vco_current_rate,
pll_7nm->vco_ref_clk_rate); pll_7nm->vco_ref_clk_rate);
if (ret) { if (ret) {
DRM_DEV_ERROR(&pll_7nm->pdev->dev, DRM_DEV_ERROR(&pll_7nm->phy->pdev->dev,
"restore vco rate failed. ret=%d\n", ret); "restore vco rate failed. ret=%d\n", ret);
return ret; return ret;
} }
DBG("DSI PLL%d", pll_7nm->id); DBG("DSI PLL%d", pll_7nm->phy->id);
return 0; return 0;
} }
...@@ -613,13 +610,13 @@ static int dsi_7nm_set_usecase(struct msm_dsi_phy *phy) ...@@ -613,13 +610,13 @@ static int dsi_7nm_set_usecase(struct msm_dsi_phy *phy)
void __iomem *base = phy->base; void __iomem *base = phy->base;
u32 data = 0x0; /* internal PLL */ u32 data = 0x0; /* internal PLL */
DBG("DSI PLL%d", pll_7nm->id); DBG("DSI PLL%d", pll_7nm->phy->id);
switch (phy->usecase) { switch (phy->usecase) {
case MSM_DSI_PHY_STANDALONE: case MSM_DSI_PHY_STANDALONE:
break; break;
case MSM_DSI_PHY_MASTER: case MSM_DSI_PHY_MASTER:
pll_7nm->slave = pll_7nm_list[(pll_7nm->id + 1) % DSI_MAX]; pll_7nm->slave = pll_7nm_list[(pll_7nm->phy->id + 1) % DSI_MAX];
break; break;
case MSM_DSI_PHY_SLAVE: case MSM_DSI_PHY_SLAVE:
data = 0x1; /* external PLL */ data = 0x1; /* external PLL */
...@@ -651,21 +648,21 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide ...@@ -651,21 +648,21 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide
.flags = CLK_IGNORE_UNUSED, .flags = CLK_IGNORE_UNUSED,
.ops = &clk_ops_dsi_pll_7nm_vco, .ops = &clk_ops_dsi_pll_7nm_vco,
}; };
struct device *dev = &pll_7nm->pdev->dev; struct device *dev = &pll_7nm->phy->pdev->dev;
struct clk_hw *hw; struct clk_hw *hw;
int ret; int ret;
DBG("DSI%d", pll_7nm->id); DBG("DSI%d", pll_7nm->phy->id);
snprintf(vco_name, 32, "dsi%dvco_clk", pll_7nm->id); snprintf(vco_name, 32, "dsi%dvco_clk", pll_7nm->phy->id);
pll_7nm->clk_hw.init = &vco_init; pll_7nm->clk_hw.init = &vco_init;
ret = devm_clk_hw_register(dev, &pll_7nm->clk_hw); ret = devm_clk_hw_register(dev, &pll_7nm->clk_hw);
if (ret) if (ret)
return ret; return ret;
snprintf(clk_name, 32, "dsi%d_pll_out_div_clk", pll_7nm->id); snprintf(clk_name, 32, "dsi%d_pll_out_div_clk", pll_7nm->phy->id);
snprintf(parent, 32, "dsi%dvco_clk", pll_7nm->id); snprintf(parent, 32, "dsi%dvco_clk", pll_7nm->phy->id);
hw = devm_clk_hw_register_divider(dev, clk_name, hw = devm_clk_hw_register_divider(dev, clk_name,
parent, CLK_SET_RATE_PARENT, parent, CLK_SET_RATE_PARENT,
...@@ -677,8 +674,8 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide ...@@ -677,8 +674,8 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide
goto fail; goto fail;
} }
snprintf(clk_name, 32, "dsi%d_pll_bit_clk", pll_7nm->id); snprintf(clk_name, 32, "dsi%d_pll_bit_clk", pll_7nm->phy->id);
snprintf(parent, 32, "dsi%d_pll_out_div_clk", pll_7nm->id); snprintf(parent, 32, "dsi%d_pll_out_div_clk", pll_7nm->phy->id);
/* BIT CLK: DIV_CTRL_3_0 */ /* BIT CLK: DIV_CTRL_3_0 */
hw = devm_clk_hw_register_divider(dev, clk_name, parent, hw = devm_clk_hw_register_divider(dev, clk_name, parent,
...@@ -692,8 +689,8 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide ...@@ -692,8 +689,8 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide
goto fail; goto fail;
} }
snprintf(clk_name, 32, "dsi%d_phy_pll_out_byteclk", pll_7nm->id); snprintf(clk_name, 32, "dsi%d_phy_pll_out_byteclk", pll_7nm->phy->id);
snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_7nm->id); snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_7nm->phy->id);
/* DSI Byte clock = VCO_CLK / OUT_DIV / BIT_DIV / 8 */ /* DSI Byte clock = VCO_CLK / OUT_DIV / BIT_DIV / 8 */
hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent, hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent,
...@@ -705,8 +702,8 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide ...@@ -705,8 +702,8 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide
provided_clocks[DSI_BYTE_PLL_CLK] = hw; provided_clocks[DSI_BYTE_PLL_CLK] = hw;
snprintf(clk_name, 32, "dsi%d_pll_by_2_bit_clk", pll_7nm->id); snprintf(clk_name, 32, "dsi%d_pll_by_2_bit_clk", pll_7nm->phy->id);
snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_7nm->id); snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_7nm->phy->id);
hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent, hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent,
0, 1, 2); 0, 1, 2);
...@@ -715,8 +712,8 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide ...@@ -715,8 +712,8 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide
goto fail; goto fail;
} }
snprintf(clk_name, 32, "dsi%d_pll_post_out_div_clk", pll_7nm->id); snprintf(clk_name, 32, "dsi%d_pll_post_out_div_clk", pll_7nm->phy->id);
snprintf(parent, 32, "dsi%d_pll_out_div_clk", pll_7nm->id); snprintf(parent, 32, "dsi%d_pll_out_div_clk", pll_7nm->phy->id);
hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent, hw = devm_clk_hw_register_fixed_factor(dev, clk_name, parent,
0, 1, 4); 0, 1, 4);
...@@ -725,11 +722,11 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide ...@@ -725,11 +722,11 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide
goto fail; goto fail;
} }
snprintf(clk_name, 32, "dsi%d_pclk_mux", pll_7nm->id); snprintf(clk_name, 32, "dsi%d_pclk_mux", pll_7nm->phy->id);
snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_7nm->id); snprintf(parent, 32, "dsi%d_pll_bit_clk", pll_7nm->phy->id);
snprintf(parent2, 32, "dsi%d_pll_by_2_bit_clk", pll_7nm->id); snprintf(parent2, 32, "dsi%d_pll_by_2_bit_clk", pll_7nm->phy->id);
snprintf(parent3, 32, "dsi%d_pll_out_div_clk", pll_7nm->id); snprintf(parent3, 32, "dsi%d_pll_out_div_clk", pll_7nm->phy->id);
snprintf(parent4, 32, "dsi%d_pll_post_out_div_clk", pll_7nm->id); snprintf(parent4, 32, "dsi%d_pll_post_out_div_clk", pll_7nm->phy->id);
hw = devm_clk_hw_register_mux(dev, clk_name, hw = devm_clk_hw_register_mux(dev, clk_name,
((const char *[]){ ((const char *[]){
...@@ -742,8 +739,8 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide ...@@ -742,8 +739,8 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide
goto fail; goto fail;
} }
snprintf(clk_name, 32, "dsi%d_phy_pll_out_dsiclk", pll_7nm->id); snprintf(clk_name, 32, "dsi%d_phy_pll_out_dsiclk", pll_7nm->phy->id);
snprintf(parent, 32, "dsi%d_pclk_mux", pll_7nm->id); snprintf(parent, 32, "dsi%d_pclk_mux", pll_7nm->phy->id);
/* PIX CLK DIV : DIV_CTRL_7_4*/ /* PIX CLK DIV : DIV_CTRL_7_4*/
hw = devm_clk_hw_register_divider(dev, clk_name, parent, hw = devm_clk_hw_register_divider(dev, clk_name, parent,
...@@ -768,7 +765,6 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide ...@@ -768,7 +765,6 @@ static int pll_7nm_register(struct dsi_pll_7nm *pll_7nm, struct clk_hw **provide
static int dsi_pll_7nm_init(struct msm_dsi_phy *phy) static int dsi_pll_7nm_init(struct msm_dsi_phy *phy)
{ {
struct platform_device *pdev = phy->pdev; struct platform_device *pdev = phy->pdev;
int id = phy->id;
struct dsi_pll_7nm *pll_7nm; struct dsi_pll_7nm *pll_7nm;
int ret; int ret;
...@@ -776,11 +772,9 @@ static int dsi_pll_7nm_init(struct msm_dsi_phy *phy) ...@@ -776,11 +772,9 @@ static int dsi_pll_7nm_init(struct msm_dsi_phy *phy)
if (!pll_7nm) if (!pll_7nm)
return -ENOMEM; return -ENOMEM;
DBG("DSI PLL%d", id); DBG("DSI PLL%d", phy->id);
pll_7nm->pdev = pdev; pll_7nm_list[phy->id] = pll_7nm;
pll_7nm->id = id;
pll_7nm_list[id] = pll_7nm;
spin_lock_init(&pll_7nm->postdiv_lock); spin_lock_init(&pll_7nm->postdiv_lock);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7