Commit a00afb97 authored by Jean Delvare's avatar Jean Delvare

hwmon: (it87) Don't arbitrarily enable temperature channels

Temperature channels can be used in 2 different modes (thermistor and
thermal diode) and we don't know which one, if any, is correct for
every given board. So don't arbitrarily choose one. Instead, leave the
temperature channels untouched. They can be configured from user-space
if needed anyway.
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent c7a78d2c
...@@ -545,6 +545,7 @@ static ssize_t set_sensor(struct device *dev, struct device_attribute *attr, ...@@ -545,6 +545,7 @@ static ssize_t set_sensor(struct device *dev, struct device_attribute *attr,
mutex_lock(&data->update_lock); mutex_lock(&data->update_lock);
data->sensor = it87_read_value(data, IT87_REG_TEMP_ENABLE);
data->sensor &= ~(1 << nr); data->sensor &= ~(1 << nr);
data->sensor &= ~(8 << nr); data->sensor &= ~(8 << nr);
if (val == 2) { /* backwards compatibility */ if (val == 2) { /* backwards compatibility */
...@@ -1841,14 +1842,10 @@ static void __devinit it87_init_device(struct platform_device *pdev) ...@@ -1841,14 +1842,10 @@ static void __devinit it87_init_device(struct platform_device *pdev)
it87_write_value(data, IT87_REG_TEMP_HIGH(i), 127); it87_write_value(data, IT87_REG_TEMP_HIGH(i), 127);
} }
/* Check if temperature channels are reset manually or by some reason */ /* Temperature channels are not forcibly enabled, as they can be
tmp = it87_read_value(data, IT87_REG_TEMP_ENABLE); * set to two different sensor types and we can't guess which one
if ((tmp & 0x3f) == 0) { * is correct for a given system. These channels can be enabled at
/* Temp1,Temp3=thermistor; Temp2=thermal diode */ * run-time through the temp{1-3}_type sysfs accessors if needed. */
tmp = (tmp & 0xc0) | 0x2a;
it87_write_value(data, IT87_REG_TEMP_ENABLE, tmp);
}
data->sensor = tmp;
/* Check if voltage monitors are reset manually or by some reason */ /* Check if voltage monitors are reset manually or by some reason */
tmp = it87_read_value(data, IT87_REG_VIN_ENABLE); tmp = it87_read_value(data, IT87_REG_VIN_ENABLE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment