Commit a03ed289 authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Greg Kroah-Hartman

drm/mediatek: mtk_drm_drv.c: Add of_node_put() before goto

commit 165d42c0 upstream.

Each iteration of for_each_child_of_node puts the previous
node, but in the case of a goto from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
goto in two places.
Issue found with Coccinelle.

Fixes: 119f5173 (drm/mediatek: Add DRM Driver for Mediatek SoC MT8173)
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarCK Hu <ck.hu@mediatek.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d13a836d
...@@ -566,12 +566,15 @@ static int mtk_drm_probe(struct platform_device *pdev) ...@@ -566,12 +566,15 @@ static int mtk_drm_probe(struct platform_device *pdev)
comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL); comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL);
if (!comp) { if (!comp) {
ret = -ENOMEM; ret = -ENOMEM;
of_node_put(node);
goto err_node; goto err_node;
} }
ret = mtk_ddp_comp_init(dev, node, comp, comp_id, NULL); ret = mtk_ddp_comp_init(dev, node, comp, comp_id, NULL);
if (ret) if (ret) {
of_node_put(node);
goto err_node; goto err_node;
}
private->ddp_comp[comp_id] = comp; private->ddp_comp[comp_id] = comp;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment