Commit a092b723 authored by Himadri Pandya's avatar Himadri Pandya Committed by David S. Miller

net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()

The buffer size is 2 Bytes and we expect to receive the same amount of
data. But sometimes we receive less data and run into uninit-was-stored
issue upon read. Hence modify the error check on the return value to match
with the buffer size as a prevention.

Reported-and-tested by: syzbot+a7e220df5a81d1ab400e@syzkaller.appspotmail.com
Signed-off-by: default avatarHimadri Pandya <himadrispandya@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5875568a
...@@ -296,7 +296,7 @@ int asix_read_phy_addr(struct usbnet *dev, int internal) ...@@ -296,7 +296,7 @@ int asix_read_phy_addr(struct usbnet *dev, int internal)
netdev_dbg(dev->net, "asix_get_phy_addr()\n"); netdev_dbg(dev->net, "asix_get_phy_addr()\n");
if (ret < 0) { if (ret < 2) {
netdev_err(dev->net, "Error reading PHYID register: %02x\n", ret); netdev_err(dev->net, "Error reading PHYID register: %02x\n", ret);
goto out; goto out;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment