Commit a11a2bf4 authored by Trond Myklebust's avatar Trond Myklebust

SUNRPC: Optimise away unnecessary data moves in xdr_align_pages

We only have to call xdr_shrink_pagelen() if the remaining RPC
message does not fit in the page buffer length that we supplied
to xdr_align_pages().
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 13fe4ba1
...@@ -730,21 +730,24 @@ static unsigned int xdr_align_pages(struct xdr_stream *xdr, unsigned int len) ...@@ -730,21 +730,24 @@ static unsigned int xdr_align_pages(struct xdr_stream *xdr, unsigned int len)
if (xdr->nwords == 0) if (xdr->nwords == 0)
return 0; return 0;
if (nwords > xdr->nwords) {
nwords = xdr->nwords;
len = nwords << 2;
}
/* Realign pages to current pointer position */ /* Realign pages to current pointer position */
iov = buf->head; iov = buf->head;
if (iov->iov_len > cur) if (iov->iov_len > cur) {
xdr_shrink_bufhead(buf, iov->iov_len - cur); xdr_shrink_bufhead(buf, iov->iov_len - cur);
xdr->nwords = XDR_QUADLEN(buf->len - cur);
}
/* Truncate page data and move it into the tail */ if (nwords > xdr->nwords) {
if (buf->page_len > len) nwords = xdr->nwords;
xdr_shrink_pagelen(buf, buf->page_len - len); len = nwords << 2;
else }
if (buf->page_len <= len)
len = buf->page_len; len = buf->page_len;
xdr->nwords = XDR_QUADLEN(buf->len - cur); else if (nwords < xdr->nwords) {
/* Truncate page data and move it into the tail */
xdr_shrink_pagelen(buf, buf->page_len - len);
xdr->nwords = XDR_QUADLEN(buf->len - cur);
}
return len; return len;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment