Commit a1221703 authored by Pietro Borrello's avatar Pietro Borrello Committed by Jakub Kicinski

sctp: sctp_sock_filter(): avoid list_entry() on possibly empty list

Use list_is_first() to check whether tsp->asoc matches the first
element of ep->asocs, as the list is not guaranteed to have an entry.

Fixes: 8f840e47 ("sctp: add the sctp_diag.c file")
Signed-off-by: default avatarPietro Borrello <borrello@diag.uniroma1.it>
Acked-by: default avatarXin Long <lucien.xin@gmail.com>
Link: https://lore.kernel.org/r/20230208-sctp-filter-v2-1-6e1f4017f326@diag.uniroma1.itSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0ed577e7
...@@ -343,11 +343,9 @@ static int sctp_sock_filter(struct sctp_endpoint *ep, struct sctp_transport *tsp ...@@ -343,11 +343,9 @@ static int sctp_sock_filter(struct sctp_endpoint *ep, struct sctp_transport *tsp
struct sctp_comm_param *commp = p; struct sctp_comm_param *commp = p;
struct sock *sk = ep->base.sk; struct sock *sk = ep->base.sk;
const struct inet_diag_req_v2 *r = commp->r; const struct inet_diag_req_v2 *r = commp->r;
struct sctp_association *assoc =
list_entry(ep->asocs.next, struct sctp_association, asocs);
/* find the ep only once through the transports by this condition */ /* find the ep only once through the transports by this condition */
if (tsp->asoc != assoc) if (!list_is_first(&tsp->asoc->asocs, &ep->asocs))
return 0; return 0;
if (r->sdiag_family != AF_UNSPEC && sk->sk_family != r->sdiag_family) if (r->sdiag_family != AF_UNSPEC && sk->sk_family != r->sdiag_family)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment