Commit a13bb2c0 authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba

btrfs: add missing iputs on orphan cleanup failure

We missed a couple of iput()s in the orphan cleanup failure paths, add
them so we don't get refcount errors. The iput needs to be done in the
check and not under a common label due to the way the code is
structured.
Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 9cf14029
...@@ -3691,6 +3691,7 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) ...@@ -3691,6 +3691,7 @@ int btrfs_orphan_cleanup(struct btrfs_root *root)
trans = btrfs_start_transaction(root, 1); trans = btrfs_start_transaction(root, 1);
if (IS_ERR(trans)) { if (IS_ERR(trans)) {
ret = PTR_ERR(trans); ret = PTR_ERR(trans);
iput(inode);
goto out; goto out;
} }
btrfs_debug(fs_info, "auto deleting %Lu", btrfs_debug(fs_info, "auto deleting %Lu",
...@@ -3698,8 +3699,10 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) ...@@ -3698,8 +3699,10 @@ int btrfs_orphan_cleanup(struct btrfs_root *root)
ret = btrfs_del_orphan_item(trans, root, ret = btrfs_del_orphan_item(trans, root,
found_key.objectid); found_key.objectid);
btrfs_end_transaction(trans); btrfs_end_transaction(trans);
if (ret) if (ret) {
iput(inode);
goto out; goto out;
}
continue; continue;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment