Commit a1fe33af authored by Chao Yu's avatar Chao Yu Committed by Richard Weinberger

ubifs: fix to check error code of register_shrinker

register_shrinker() in ubifs_init() can fail due to fail to call kzalloc.
This patch fixes to check the return value of register_shrinker, otherwise
our shrinker may be unregistered after ubifs initialized successfully.
Signed-off-by: default avatarChao Yu <chao2.yu@samsung.com>
Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 2bf50d42
...@@ -2245,7 +2245,9 @@ static int __init ubifs_init(void) ...@@ -2245,7 +2245,9 @@ static int __init ubifs_init(void)
if (!ubifs_inode_slab) if (!ubifs_inode_slab)
return -ENOMEM; return -ENOMEM;
register_shrinker(&ubifs_shrinker_info); err = register_shrinker(&ubifs_shrinker_info);
if (err)
goto out_slab;
err = ubifs_compressors_init(); err = ubifs_compressors_init();
if (err) if (err)
...@@ -2269,6 +2271,7 @@ static int __init ubifs_init(void) ...@@ -2269,6 +2271,7 @@ static int __init ubifs_init(void)
ubifs_compressors_exit(); ubifs_compressors_exit();
out_shrinker: out_shrinker:
unregister_shrinker(&ubifs_shrinker_info); unregister_shrinker(&ubifs_shrinker_info);
out_slab:
kmem_cache_destroy(ubifs_inode_slab); kmem_cache_destroy(ubifs_inode_slab);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment