Commit a26b7719 authored by Christophe Saout's avatar Christophe Saout Committed by Adrian Bunk

dm crypt: Fix data corruption with dm-crypt over RAID5

Fix corruption issue with dm-crypt on top of software raid5. Cancelled
readahead bio's that report no error, just have BIO_UPTODATE cleared
were reported as successful reads to the higher layers (and leaving
random content in the buffer cache). Already fixed in 2.6.19.
Signed-off-by: default avatarChristophe Saout <christophe@saout.de>
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
parent bbb97831
...@@ -730,13 +730,15 @@ static int crypt_endio(struct bio *bio, unsigned int done, int error) ...@@ -730,13 +730,15 @@ static int crypt_endio(struct bio *bio, unsigned int done, int error)
if (bio->bi_size) if (bio->bi_size)
return 1; return 1;
if (!bio_flagged(bio, BIO_UPTODATE) && !error)
error = -EIO;
bio_put(bio); bio_put(bio);
/* /*
* successful reads are decrypted by the worker thread * successful reads are decrypted by the worker thread
*/ */
if ((bio_data_dir(bio) == READ) if (bio_data_dir(io->bio) == READ && !error) {
&& bio_flagged(bio, BIO_UPTODATE)) {
kcryptd_queue_io(io); kcryptd_queue_io(io);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment