Commit a465321a authored by Shuah Khan's avatar Shuah Khan Committed by Mauro Carvalho Chehab

media: s5p-mfc: Remove firmware buf null check in s5p_mfc_load_firmware()

s5p_mfc_load_firmware() will not get called if fw_buf.virt allocation
fails. The allocation happens very early on in the probe routine and
probe fails if allocation fails.

There is no need to check if it is null in s5p_mfc_load_firmware().
Remove the check.
Signed-off-by: default avatarShuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent bc7eb5d7
...@@ -75,11 +75,6 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev) ...@@ -75,11 +75,6 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev)
release_firmware(fw_blob); release_firmware(fw_blob);
return -ENOMEM; return -ENOMEM;
} }
if (!dev->fw_buf.virt) {
mfc_err("MFC firmware is not allocated\n");
release_firmware(fw_blob);
return -EINVAL;
}
memcpy(dev->fw_buf.virt, fw_blob->data, fw_blob->size); memcpy(dev->fw_buf.virt, fw_blob->data, fw_blob->size);
wmb(); wmb();
release_firmware(fw_blob); release_firmware(fw_blob);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment