Commit a4f2473d authored by Takashi Iwai's avatar Takashi Iwai

ALSA: atmel: Convert to snd_card_new() with a device pointer

Also remove superfluous snd_card_set_dev() calls.
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 4a875580
...@@ -429,8 +429,9 @@ static int atmel_abdac_probe(struct platform_device *pdev) ...@@ -429,8 +429,9 @@ static int atmel_abdac_probe(struct platform_device *pdev)
} }
clk_enable(pclk); clk_enable(pclk);
retval = snd_card_create(SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1, retval = snd_card_new(&pdev->dev, SNDRV_DEFAULT_IDX1,
THIS_MODULE, sizeof(struct atmel_abdac), &card); SNDRV_DEFAULT_STR1, THIS_MODULE,
sizeof(struct atmel_abdac), &card);
if (retval) { if (retval) {
dev_dbg(&pdev->dev, "could not create sound card device\n"); dev_dbg(&pdev->dev, "could not create sound card device\n");
goto out_put_sample_clk; goto out_put_sample_clk;
...@@ -467,8 +468,6 @@ static int atmel_abdac_probe(struct platform_device *pdev) ...@@ -467,8 +468,6 @@ static int atmel_abdac_probe(struct platform_device *pdev)
goto out_unmap_regs; goto out_unmap_regs;
} }
snd_card_set_dev(card, &pdev->dev);
if (pdata->dws.dma_dev) { if (pdata->dws.dma_dev) {
dma_cap_mask_t mask; dma_cap_mask_t mask;
...@@ -492,7 +491,7 @@ static int atmel_abdac_probe(struct platform_device *pdev) ...@@ -492,7 +491,7 @@ static int atmel_abdac_probe(struct platform_device *pdev)
if (!pdata->dws.dma_dev || !dac->dma.chan) { if (!pdata->dws.dma_dev || !dac->dma.chan) {
dev_dbg(&pdev->dev, "DMA not available\n"); dev_dbg(&pdev->dev, "DMA not available\n");
retval = -ENODEV; retval = -ENODEV;
goto out_unset_card_dev; goto out_unmap_regs;
} }
strcpy(card->driver, "Atmel ABDAC"); strcpy(card->driver, "Atmel ABDAC");
...@@ -521,9 +520,6 @@ static int atmel_abdac_probe(struct platform_device *pdev) ...@@ -521,9 +520,6 @@ static int atmel_abdac_probe(struct platform_device *pdev)
out_release_dma: out_release_dma:
dma_release_channel(dac->dma.chan); dma_release_channel(dac->dma.chan);
dac->dma.chan = NULL; dac->dma.chan = NULL;
out_unset_card_dev:
snd_card_set_dev(card, NULL);
free_irq(irq, dac);
out_unmap_regs: out_unmap_regs:
iounmap(dac->regs); iounmap(dac->regs);
out_free_card: out_free_card:
...@@ -579,7 +575,6 @@ static int atmel_abdac_remove(struct platform_device *pdev) ...@@ -579,7 +575,6 @@ static int atmel_abdac_remove(struct platform_device *pdev)
dma_release_channel(dac->dma.chan); dma_release_channel(dac->dma.chan);
dac->dma.chan = NULL; dac->dma.chan = NULL;
snd_card_set_dev(card, NULL);
iounmap(dac->regs); iounmap(dac->regs);
free_irq(dac->irq, dac); free_irq(dac->irq, dac);
snd_card_free(card); snd_card_free(card);
......
...@@ -945,8 +945,9 @@ static int atmel_ac97c_probe(struct platform_device *pdev) ...@@ -945,8 +945,9 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
} }
clk_enable(pclk); clk_enable(pclk);
retval = snd_card_create(SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1, retval = snd_card_new(&pdev->dev, SNDRV_DEFAULT_IDX1,
THIS_MODULE, sizeof(struct atmel_ac97c), &card); SNDRV_DEFAULT_STR1, THIS_MODULE,
sizeof(struct atmel_ac97c), &card);
if (retval) { if (retval) {
dev_dbg(&pdev->dev, "could not create sound card device\n"); dev_dbg(&pdev->dev, "could not create sound card device\n");
goto err_snd_card_new; goto err_snd_card_new;
...@@ -990,8 +991,6 @@ static int atmel_ac97c_probe(struct platform_device *pdev) ...@@ -990,8 +991,6 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
chip->reset_pin = -EINVAL; chip->reset_pin = -EINVAL;
} }
snd_card_set_dev(card, &pdev->dev);
atmel_ac97c_reset(chip); atmel_ac97c_reset(chip);
/* Enable overrun interrupt from codec channel */ /* Enable overrun interrupt from codec channel */
...@@ -1113,8 +1112,6 @@ static int atmel_ac97c_probe(struct platform_device *pdev) ...@@ -1113,8 +1112,6 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
chip->dma.tx_chan = NULL; chip->dma.tx_chan = NULL;
} }
err_ac97_bus: err_ac97_bus:
snd_card_set_dev(card, NULL);
if (gpio_is_valid(chip->reset_pin)) if (gpio_is_valid(chip->reset_pin))
gpio_free(chip->reset_pin); gpio_free(chip->reset_pin);
...@@ -1195,7 +1192,6 @@ static int atmel_ac97c_remove(struct platform_device *pdev) ...@@ -1195,7 +1192,6 @@ static int atmel_ac97c_remove(struct platform_device *pdev)
chip->dma.tx_chan = NULL; chip->dma.tx_chan = NULL;
} }
snd_card_set_dev(card, NULL);
snd_card_free(card); snd_card_free(card);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment