Commit a567abf6 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Jonathan Cameron

iio: dac: dpot-dac: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarPeter Rosin <peda@axentia.se>
Link: https://lore.kernel.org/r/20200829064726.26268-12-krzk@kernel.orgSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent ed175909
...@@ -183,18 +183,14 @@ static int dpot_dac_probe(struct platform_device *pdev) ...@@ -183,18 +183,14 @@ static int dpot_dac_probe(struct platform_device *pdev)
indio_dev->num_channels = 1; indio_dev->num_channels = 1;
dac->vref = devm_regulator_get(dev, "vref"); dac->vref = devm_regulator_get(dev, "vref");
if (IS_ERR(dac->vref)) { if (IS_ERR(dac->vref))
if (PTR_ERR(dac->vref) != -EPROBE_DEFER) return dev_err_probe(&pdev->dev, PTR_ERR(dac->vref),
dev_err(&pdev->dev, "failed to get vref regulator\n"); "failed to get vref regulator\n");
return PTR_ERR(dac->vref);
}
dac->dpot = devm_iio_channel_get(dev, "dpot"); dac->dpot = devm_iio_channel_get(dev, "dpot");
if (IS_ERR(dac->dpot)) { if (IS_ERR(dac->dpot))
if (PTR_ERR(dac->dpot) != -EPROBE_DEFER) return dev_err_probe(&pdev->dev, PTR_ERR(dac->dpot),
dev_err(dev, "failed to get dpot input channel\n"); "failed to get dpot input channel\n");
return PTR_ERR(dac->dpot);
}
ret = iio_get_channel_type(dac->dpot, &type); ret = iio_get_channel_type(dac->dpot, &type);
if (ret < 0) if (ret < 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment