Commit a5de681c authored by Frans Klaver's avatar Frans Klaver Committed by Darren Hart

eeepc-laptop: replace magic numbers with defines

eeepc_[gs]et_fan_ctrl uses some magic numbers. These numbers mean
something more than just the number. Describe them with macros instead
of comments in one of the functions.
Signed-off-by: default avatarFrans Klaver <fransklaver@gmail.com>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent 792bd2a5
...@@ -1005,15 +1005,19 @@ static int eeepc_get_fan_rpm(void) ...@@ -1005,15 +1005,19 @@ static int eeepc_get_fan_rpm(void)
return high << 8 | low; return high << 8 | low;
} }
#define EEEPC_EC_FAN_CTRL_BIT 0x02
#define EEEPC_FAN_CTRL_MANUAL 1
#define EEEPC_FAN_CTRL_AUTO 2
static int eeepc_get_fan_ctrl(void) static int eeepc_get_fan_ctrl(void)
{ {
u8 value = 0; u8 value = 0;
ec_read(EEEPC_EC_FAN_CTRL, &value); ec_read(EEEPC_EC_FAN_CTRL, &value);
if (value & 0x02) if (value & EEEPC_EC_FAN_CTRL_BIT)
return 1; /* manual */ return EEEPC_FAN_CTRL_MANUAL;
else else
return 2; /* automatic */ return EEEPC_FAN_CTRL_AUTO;
} }
static void eeepc_set_fan_ctrl(int manual) static void eeepc_set_fan_ctrl(int manual)
...@@ -1021,10 +1025,10 @@ static void eeepc_set_fan_ctrl(int manual) ...@@ -1021,10 +1025,10 @@ static void eeepc_set_fan_ctrl(int manual)
u8 value = 0; u8 value = 0;
ec_read(EEEPC_EC_FAN_CTRL, &value); ec_read(EEEPC_EC_FAN_CTRL, &value);
if (manual == 1) if (manual == EEEPC_FAN_CTRL_MANUAL)
value |= 0x02; value |= EEEPC_EC_FAN_CTRL_BIT;
else else
value &= ~0x02; value &= ~EEEPC_EC_FAN_CTRL_BIT;
ec_write(EEEPC_EC_FAN_CTRL, value); ec_write(EEEPC_EC_FAN_CTRL, value);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment