Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
linux
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
linux
Commits
a5ec7f86
Commit
a5ec7f86
authored
Jul 03, 2011
by
James Bottomley
Committed by
James Bottomley
Jul 03, 2011
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[SCSI] isci: fix checkpatch errors
Signed-off-by:
James Bottomley
<
JBottomley@Parallels.com
>
parent
5b45b69c
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
44 additions
and
42 deletions
+44
-42
drivers/scsi/isci/phy.c
drivers/scsi/isci/phy.c
+1
-1
drivers/scsi/isci/probe_roms.c
drivers/scsi/isci/probe_roms.c
+4
-3
drivers/scsi/isci/remote_device.c
drivers/scsi/isci/remote_device.c
+1
-1
drivers/scsi/isci/request.h
drivers/scsi/isci/request.h
+2
-2
drivers/scsi/isci/task.c
drivers/scsi/isci/task.c
+36
-35
No files found.
drivers/scsi/isci/phy.c
View file @
a5ec7f86
...
@@ -197,7 +197,7 @@ sci_phy_link_layer_initialization(struct isci_phy *iphy,
...
@@ -197,7 +197,7 @@ sci_phy_link_layer_initialization(struct isci_phy *iphy,
llctl
=
SCU_SAS_LLCTL_GEN_VAL
(
NO_OUTBOUND_TASK_TIMEOUT
,
llctl
=
SCU_SAS_LLCTL_GEN_VAL
(
NO_OUTBOUND_TASK_TIMEOUT
,
(
u8
)
ihost
->
user_parameters
.
no_outbound_task_timeout
);
(
u8
)
ihost
->
user_parameters
.
no_outbound_task_timeout
);
switch
(
phy_user
->
max_speed_generation
)
{
switch
(
phy_user
->
max_speed_generation
)
{
case
SCIC_SDS_PARM_GEN3_SPEED
:
case
SCIC_SDS_PARM_GEN3_SPEED
:
link_rate
=
SCU_SAS_LINK_LAYER_CONTROL_MAX_LINK_RATE_GEN3
;
link_rate
=
SCU_SAS_LINK_LAYER_CONTROL_MAX_LINK_RATE_GEN3
;
break
;
break
;
...
...
drivers/scsi/isci/probe_roms.c
View file @
a5ec7f86
...
@@ -34,8 +34,9 @@
...
@@ -34,8 +34,9 @@
#include "task.h"
#include "task.h"
#include "probe_roms.h"
#include "probe_roms.h"
static
efi_char16_t
isci_efivar_name
[]
=
static
efi_char16_t
isci_efivar_name
[]
=
{
{
'R'
,
's'
,
't'
,
'S'
,
'c'
,
'u'
,
'O'
};
'R'
,
's'
,
't'
,
'S'
,
'c'
,
'u'
,
'O'
};
struct
isci_orom
*
isci_request_oprom
(
struct
pci_dev
*
pdev
)
struct
isci_orom
*
isci_request_oprom
(
struct
pci_dev
*
pdev
)
{
{
...
@@ -182,7 +183,7 @@ struct isci_orom *isci_get_efi_var(struct pci_dev *pdev)
...
@@ -182,7 +183,7 @@ struct isci_orom *isci_get_efi_var(struct pci_dev *pdev)
struct
isci_oem_hdr
*
oem_hdr
;
struct
isci_oem_hdr
*
oem_hdr
;
u8
*
tmp
,
sum
;
u8
*
tmp
,
sum
;
int
j
;
int
j
;
ssize_t
data_len
;
unsigned
long
data_len
;
u8
*
efi_data
;
u8
*
efi_data
;
u32
efi_attrib
=
0
;
u32
efi_attrib
=
0
;
...
...
drivers/scsi/isci/remote_device.c
View file @
a5ec7f86
...
@@ -73,7 +73,7 @@
...
@@ -73,7 +73,7 @@
static
void
isci_remote_device_not_ready
(
struct
isci_host
*
ihost
,
static
void
isci_remote_device_not_ready
(
struct
isci_host
*
ihost
,
struct
isci_remote_device
*
idev
,
u32
reason
)
struct
isci_remote_device
*
idev
,
u32
reason
)
{
{
struct
isci_request
*
ireq
;
struct
isci_request
*
ireq
;
dev_dbg
(
&
ihost
->
pdev
->
dev
,
dev_dbg
(
&
ihost
->
pdev
->
dev
,
"%s: isci_device = %p
\n
"
,
__func__
,
idev
);
"%s: isci_device = %p
\n
"
,
__func__
,
idev
);
...
...
drivers/scsi/isci/request.h
View file @
a5ec7f86
...
@@ -440,8 +440,8 @@ void sci_smp_request_copy_response(struct isci_request *ireq);
...
@@ -440,8 +440,8 @@ void sci_smp_request_copy_response(struct isci_request *ireq);
static
inline
int
isci_task_is_ncq_recovery
(
struct
sas_task
*
task
)
static
inline
int
isci_task_is_ncq_recovery
(
struct
sas_task
*
task
)
{
{
return
(
sas_protocol_ata
(
task
->
task_proto
)
&&
return
(
sas_protocol_ata
(
task
->
task_proto
)
&&
task
->
ata_task
.
fis
.
command
==
ATA_CMD_READ_LOG_EXT
&&
task
->
ata_task
.
fis
.
command
==
ATA_CMD_READ_LOG_EXT
&&
task
->
ata_task
.
fis
.
lbal
==
ATA_LOG_SATA_NCQ
);
task
->
ata_task
.
fis
.
lbal
==
ATA_LOG_SATA_NCQ
);
}
}
...
...
drivers/scsi/isci/task.c
View file @
a5ec7f86
...
@@ -88,44 +88,45 @@ static void isci_task_refuse(struct isci_host *ihost, struct sas_task *task,
...
@@ -88,44 +88,45 @@ static void isci_task_refuse(struct isci_host *ihost, struct sas_task *task,
* function should not be completed to the host in the regular path.
* function should not be completed to the host in the regular path.
*/
*/
switch
(
disposition
)
{
switch
(
disposition
)
{
case
isci_perform_normal_io_completion
:
case
isci_perform_normal_io_completion
:
/* Normal notification (task_done) */
/* Normal notification (task_done) */
dev_dbg
(
&
ihost
->
pdev
->
dev
,
dev_dbg
(
&
ihost
->
pdev
->
dev
,
"%s: Normal - task = %p, response=%d, "
"%s: Normal - task = %p, response=%d, "
"status=%d
\n
"
,
"status=%d
\n
"
,
__func__
,
task
,
response
,
status
);
__func__
,
task
,
response
,
status
);
task
->
lldd_task
=
NULL
;
task
->
lldd_task
=
NULL
;
isci_execpath_callback
(
ihost
,
task
,
task
->
task_done
);
isci_execpath_callback
(
ihost
,
task
,
task
->
task_done
);
break
;
break
;
case
isci_perform_aborted_io_completion
:
case
isci_perform_aborted_io_completion
:
/* No notification because this request is already in the
/*
* abort path.
* No notification because this request is already in the
*/
* abort path.
dev_dbg
(
&
ihost
->
pdev
->
dev
,
*/
"%s: Aborted - task = %p, response=%d, "
dev_dbg
(
&
ihost
->
pdev
->
dev
,
"status=%d
\n
"
,
"%s: Aborted - task = %p, response=%d, "
__func__
,
task
,
response
,
status
);
"status=%d
\n
"
,
break
;
__func__
,
task
,
response
,
status
);
break
;
case
isci_perform_error_io_completion
:
case
isci_perform_error_io_completion
:
/* Use sas_task_abort */
/* Use sas_task_abort */
dev_dbg
(
&
ihost
->
pdev
->
dev
,
dev_dbg
(
&
ihost
->
pdev
->
dev
,
"%s: Error - task = %p, response=%d, "
"%s: Error - task = %p, response=%d, "
"status=%d
\n
"
,
"status=%d
\n
"
,
__func__
,
task
,
response
,
status
);
__func__
,
task
,
response
,
status
);
isci_execpath_callback
(
ihost
,
task
,
sas_task_abort
);
isci_execpath_callback
(
ihost
,
task
,
sas_task_abort
);
break
;
break
;
default:
default:
dev_dbg
(
&
ihost
->
pdev
->
dev
,
dev_dbg
(
&
ihost
->
pdev
->
dev
,
"%s: isci task notification default case!"
,
"%s: isci task notification default case!"
,
__func__
);
__func__
);
sas_task_abort
(
task
);
sas_task_abort
(
task
);
break
;
break
;
}
}
}
}
...
@@ -1056,7 +1057,7 @@ int isci_task_abort_task(struct sas_task *task)
...
@@ -1056,7 +1057,7 @@ int isci_task_abort_task(struct sas_task *task)
dev_dbg
(
&
isci_host
->
pdev
->
dev
,
dev_dbg
(
&
isci_host
->
pdev
->
dev
,
"%s: old_request == %p
\n
"
,
__func__
,
old_request
);
"%s: old_request == %p
\n
"
,
__func__
,
old_request
);
any_dev_reset
=
isci_device_is_reset_pending
(
isci_host
,
isci_device
);
any_dev_reset
=
isci_device_is_reset_pending
(
isci_host
,
isci_device
);
spin_lock_irqsave
(
&
task
->
task_state_lock
,
flags
);
spin_lock_irqsave
(
&
task
->
task_state_lock
,
flags
);
...
@@ -1115,9 +1116,9 @@ int isci_task_abort_task(struct sas_task *task)
...
@@ -1115,9 +1116,9 @@ int isci_task_abort_task(struct sas_task *task)
__func__
,
task
);
__func__
,
task
);
}
}
goto
out
;
goto
out
;
}
}
else
{
else
spin_unlock_irqrestore
(
&
task
->
task_state_lock
,
flags
);
spin_unlock_irqrestore
(
&
task
->
task_state_lock
,
flags
);
}
spin_lock_irqsave
(
&
isci_host
->
scic_lock
,
flags
);
spin_lock_irqsave
(
&
isci_host
->
scic_lock
,
flags
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment