Commit a5f4dbf0 authored by Feng Tang's avatar Feng Tang Committed by Greg Kroah-Hartman

serial: mfd: remove the timeout workaround for A0

This is kind of a revert for commit 669b7a09 "hsu: add a periodic
timer to check dma rx channel", which is a workaround for a bug in A0
stepping silicon, where a dma rx data timeout is missing for some case.
Since new silicon has fixed it and the old version is phasing out, no
need to carry on it any more.
Signed-off-by: default avatarFeng Tang <feng.tang@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 940f3be4
...@@ -51,8 +51,6 @@ ...@@ -51,8 +51,6 @@
#define mfd_readl(obj, offset) readl(obj->reg + offset) #define mfd_readl(obj, offset) readl(obj->reg + offset)
#define mfd_writel(obj, offset, val) writel(val, obj->reg + offset) #define mfd_writel(obj, offset, val) writel(val, obj->reg + offset)
#define HSU_DMA_TIMEOUT_CHECK_FREQ (HZ/10)
struct hsu_dma_buffer { struct hsu_dma_buffer {
u8 *buf; u8 *buf;
dma_addr_t dma_addr; dma_addr_t dma_addr;
...@@ -65,7 +63,6 @@ struct hsu_dma_chan { ...@@ -65,7 +63,6 @@ struct hsu_dma_chan {
enum dma_data_direction dirt; enum dma_data_direction dirt;
struct uart_hsu_port *uport; struct uart_hsu_port *uport;
void __iomem *reg; void __iomem *reg;
struct timer_list rx_timer; /* only needed by RX channel */
}; };
struct uart_hsu_port { struct uart_hsu_port {
...@@ -355,8 +352,6 @@ void hsu_dma_start_rx_chan(struct hsu_dma_chan *rxc, struct hsu_dma_buffer *dbuf ...@@ -355,8 +352,6 @@ void hsu_dma_start_rx_chan(struct hsu_dma_chan *rxc, struct hsu_dma_buffer *dbuf
| (0x1 << 24) /* timeout bit, see HSU Errata 1 */ | (0x1 << 24) /* timeout bit, see HSU Errata 1 */
); );
chan_writel(rxc, HSU_CH_CR, 0x3); chan_writel(rxc, HSU_CH_CR, 0x3);
mod_timer(&rxc->rx_timer, jiffies + HSU_DMA_TIMEOUT_CHECK_FREQ);
} }
/* Protected by spin_lock_irqsave(port->lock) */ /* Protected by spin_lock_irqsave(port->lock) */
...@@ -420,7 +415,6 @@ void hsu_dma_rx(struct uart_hsu_port *up, u32 int_sts) ...@@ -420,7 +415,6 @@ void hsu_dma_rx(struct uart_hsu_port *up, u32 int_sts)
chan_writel(chan, HSU_CH_CR, 0x3); chan_writel(chan, HSU_CH_CR, 0x3);
return; return;
} }
del_timer(&chan->rx_timer);
dma_sync_single_for_cpu(port->dev, dbuf->dma_addr, dma_sync_single_for_cpu(port->dev, dbuf->dma_addr,
dbuf->dma_size, DMA_FROM_DEVICE); dbuf->dma_size, DMA_FROM_DEVICE);
...@@ -448,8 +442,6 @@ void hsu_dma_rx(struct uart_hsu_port *up, u32 int_sts) ...@@ -448,8 +442,6 @@ void hsu_dma_rx(struct uart_hsu_port *up, u32 int_sts)
tty_flip_buffer_push(tty); tty_flip_buffer_push(tty);
chan_writel(chan, HSU_CH_CR, 0x3); chan_writel(chan, HSU_CH_CR, 0x3);
chan->rx_timer.expires = jiffies + HSU_DMA_TIMEOUT_CHECK_FREQ;
add_timer(&chan->rx_timer);
} }
...@@ -870,8 +862,6 @@ static void serial_hsu_shutdown(struct uart_port *port) ...@@ -870,8 +862,6 @@ static void serial_hsu_shutdown(struct uart_port *port)
container_of(port, struct uart_hsu_port, port); container_of(port, struct uart_hsu_port, port);
unsigned long flags; unsigned long flags;
del_timer_sync(&up->rxc->rx_timer);
/* Disable interrupts from this port */ /* Disable interrupts from this port */
up->ier = 0; up->ier = 0;
serial_out(up, UART_IER, 0); serial_out(up, UART_IER, 0);
...@@ -1343,28 +1333,6 @@ static int serial_hsu_probe(struct pci_dev *pdev, ...@@ -1343,28 +1333,6 @@ static int serial_hsu_probe(struct pci_dev *pdev,
return ret; return ret;
} }
static void hsu_dma_rx_timeout(unsigned long data)
{
struct hsu_dma_chan *chan = (void *)data;
struct uart_hsu_port *up = chan->uport;
struct hsu_dma_buffer *dbuf = &up->rxbuf;
int count = 0;
unsigned long flags;
spin_lock_irqsave(&up->port.lock, flags);
count = chan_readl(chan, HSU_CH_D0SAR) - dbuf->dma_addr;
if (!count) {
mod_timer(&chan->rx_timer, jiffies + HSU_DMA_TIMEOUT_CHECK_FREQ);
goto exit;
}
hsu_dma_rx(up, 0);
exit:
spin_unlock_irqrestore(&up->port.lock, flags);
}
static void hsu_global_init(void) static void hsu_global_init(void)
{ {
struct hsu_port *hsu; struct hsu_port *hsu;
...@@ -1427,12 +1395,6 @@ static void hsu_global_init(void) ...@@ -1427,12 +1395,6 @@ static void hsu_global_init(void)
dchan->reg = hsu->reg + HSU_DMA_CHANS_REG_OFFSET + dchan->reg = hsu->reg + HSU_DMA_CHANS_REG_OFFSET +
i * HSU_DMA_CHANS_REG_LENGTH; i * HSU_DMA_CHANS_REG_LENGTH;
/* Work around for RX */
if (dchan->dirt == DMA_FROM_DEVICE) {
init_timer(&dchan->rx_timer);
dchan->rx_timer.function = hsu_dma_rx_timeout;
dchan->rx_timer.data = (unsigned long)dchan;
}
dchan++; dchan++;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment