Commit a62e82b3 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Dave Chinner

xfs: fix the same_inode check in xfs_file_share_range

The VFS i_ino is an unsigned long, while XFS inode numbers are 64-bit
wide, so checking i_ino for equality could lead to rate false positives
on 32-bit architectures.  Just compare the inode pointers themselves
to be safe.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent 4fbc2c65
...@@ -965,7 +965,7 @@ xfs_file_share_range( ...@@ -965,7 +965,7 @@ xfs_file_share_range(
IS_SWAPFILE(inode_out)) IS_SWAPFILE(inode_out))
return -ETXTBSY; return -ETXTBSY;
same_inode = (inode_in->i_ino == inode_out->i_ino); same_inode = (inode_in == inode_out);
/* Don't reflink dirs, pipes, sockets... */ /* Don't reflink dirs, pipes, sockets... */
if (S_ISDIR(inode_in->i_mode) || S_ISDIR(inode_out->i_mode)) if (S_ISDIR(inode_in->i_mode) || S_ISDIR(inode_out->i_mode))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment