Commit a689c582 authored by Miaohe Lin's avatar Miaohe Lin Committed by Kelsey Skunberg

net: Set fput_needed iff FDPUT_FPUT is set

BugLink: https://bugs.launchpad.net/bugs/1892822

[ Upstream commit ce787a5a ]

We should fput() file iff FDPUT_FPUT is set. So we should set fput_needed
accordingly.

Fixes: 00e188ef ("sockfd_lookup_light(): switch to fdget^W^Waway from fget_light")
Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: default avatarIan May <ian.may@canonical.com>
Signed-off-by: default avatarKelsey Skunberg <kelsey.skunberg@canonical.com>
parent 92ccbeb8
...@@ -456,7 +456,7 @@ static struct socket *sockfd_lookup_light(int fd, int *err, int *fput_needed) ...@@ -456,7 +456,7 @@ static struct socket *sockfd_lookup_light(int fd, int *err, int *fput_needed)
if (f.file) { if (f.file) {
sock = sock_from_file(f.file, err); sock = sock_from_file(f.file, err);
if (likely(sock)) { if (likely(sock)) {
*fput_needed = f.flags; *fput_needed = f.flags & FDPUT_FPUT;
return sock; return sock;
} }
fdput(f); fdput(f);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment