Commit a6a1a156 authored by Christian Lamparter's avatar Christian Lamparter Committed by Florian Fainelli

ARM: dts: BCM5301X: MR26: MR32: remove bogus nand-ecc-algo property

| bcm53015-meraki-mr26.dtb: nand-controller@18028000:
|   nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs']
| From schema: Documentation/[...]/nand-controller.yaml
| bcm53016-meraki-mr32.dtb: nand-controller@18028000:
|   nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs']
| From schema: Documentation/[...]/nand-controller.yaml

original ECC values for these old Merakis are sadly not
provided by the vendor. It looks like Meraki just stuck
with what Broadcom's SDK was doing... which left this
up to the proprietary nand driver.

Note: The invalid setting was and is handled by brcmnand. It
falls back to "bch" in brcmnand_setup_dev() when ecc.algo is
set to NAND_ECC_ALGO_UNKNOWN (since "hw" is not in the list
above).

A correct nand-ecc-algo = "bch"; is already specified in the
included  "bcm5301x-nand-cs0-bch8.dtsi". So this line can be
dropped.

Reported-by: Rafał Miłecki <zajec5@gmail.com> (per Mail)
Fixes: 935327a7 ("ARM: dts: BCM5301X: Add DT for Meraki MR26")
Fixes: ec88a9c3 ("ARM: BCM5301X: Add DT for Meraki MR32")
Signed-off-by: default avatarChristian Lamparter <chunkeey@gmail.com>
Link: https://lore.kernel.org/r/2c4d00dd40124c2ddc0b139cbce7531b108f9052.1686238550.git.chunkeey@gmail.comSigned-off-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
parent 7121458e
......@@ -72,8 +72,6 @@ &gmac3 {
};
&nandcs {
nand-ecc-algo = "hw";
partitions {
compatible = "fixed-partitions";
#address-cells = <0x1>;
......
......@@ -125,8 +125,6 @@ &pwm {
};
&nandcs {
nand-ecc-algo = "hw";
partitions {
/*
* The partition autodetection does not work for this device.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment