Commit a6ec5bb8 authored by Elise Lennion's avatar Elise Lennion Committed by Greg Kroah-Hartman

staging: lustre: Move assignments out of function calls.

Assignments inside of function calls confuse the reader and should be
avoided, so it was moved out before the call.

Found with Coccinelle, semantic patch:
@@
identifier f;
expression e1, e2;
assignment operator a;
@@

+ e1 a e2;
f(...,
- (e1 a e2)
+ e1
 ,...);
Signed-off-by: default avatarElise Lennion <elise.lennion@gmail.com>
Reviewed-by: default avatarAndreas Dilger <andreas.dilger@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f99e73a5
...@@ -450,7 +450,8 @@ static void vvp_io_advance(const struct lu_env *env, ...@@ -450,7 +450,8 @@ static void vvp_io_advance(const struct lu_env *env,
struct vvp_io *vio = cl2vvp_io(env, ios); struct vvp_io *vio = cl2vvp_io(env, ios);
CLOBINVRNT(env, obj, vvp_object_invariant(obj)); CLOBINVRNT(env, obj, vvp_object_invariant(obj));
iov_iter_reexpand(vio->vui_iter, vio->vui_tot_count -= nob); vio->vui_tot_count -= nob;
iov_iter_reexpand(vio->vui_iter, vio->vui_tot_count);
} }
static void vvp_io_update_iov(const struct lu_env *env, static void vvp_io_update_iov(const struct lu_env *env,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment