Commit a7155f4e authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

w1: small type cleanup in sysfs

On 64 bit systems, a large value for "long tmp" is truncated when
assigning to "int md->max_slave_count" so we still end up with a value
less than one despite the "tmp < 1" check.

This is more of a problem for static checkers than a real life issue,
but it's simple enough to fix.
Acked-by: default avatarDavid Fries <david@fries.net>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 83b1bfba
...@@ -320,10 +320,10 @@ static ssize_t w1_master_attribute_show_timeout(struct device *dev, struct devic ...@@ -320,10 +320,10 @@ static ssize_t w1_master_attribute_show_timeout(struct device *dev, struct devic
static ssize_t w1_master_attribute_store_max_slave_count(struct device *dev, static ssize_t w1_master_attribute_store_max_slave_count(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count) struct device_attribute *attr, const char *buf, size_t count)
{ {
long tmp; int tmp;
struct w1_master *md = dev_to_w1_master(dev); struct w1_master *md = dev_to_w1_master(dev);
if (kstrtol(buf, 0, &tmp) == -EINVAL || tmp < 1) if (kstrtoint(buf, 0, &tmp) == -EINVAL || tmp < 1)
return -EINVAL; return -EINVAL;
mutex_lock(&md->mutex); mutex_lock(&md->mutex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment