Commit a74e9426 authored by Ying Xue's avatar Ying Xue Committed by David S. Miller

caif: __dev_get_by_index instead of dev_get_by_index to find interface

The following call chains indicate that chnl_net_open() is under
rtnl_lock protection as __dev_open() is protected by rtnl_lock.
So if __dev_get_by_index() instead of dev_get_by_index() is used
to find interface handler in it, this would help us avoid to change
interface reference counter.

__dev_open()
  chnl_net_open()

Cc: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>
Signed-off-by: default avatarYing Xue <ying.xue@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 16b77695
...@@ -285,7 +285,7 @@ static int chnl_net_open(struct net_device *dev) ...@@ -285,7 +285,7 @@ static int chnl_net_open(struct net_device *dev)
goto error; goto error;
} }
lldev = dev_get_by_index(dev_net(dev), llifindex); lldev = __dev_get_by_index(dev_net(dev), llifindex);
if (lldev == NULL) { if (lldev == NULL) {
pr_debug("no interface?\n"); pr_debug("no interface?\n");
...@@ -307,7 +307,6 @@ static int chnl_net_open(struct net_device *dev) ...@@ -307,7 +307,6 @@ static int chnl_net_open(struct net_device *dev)
mtu = min_t(int, dev->mtu, lldev->mtu - (headroom + tailroom)); mtu = min_t(int, dev->mtu, lldev->mtu - (headroom + tailroom));
mtu = min_t(int, GPRS_PDP_MTU, mtu); mtu = min_t(int, GPRS_PDP_MTU, mtu);
dev_set_mtu(dev, mtu); dev_set_mtu(dev, mtu);
dev_put(lldev);
if (mtu < 100) { if (mtu < 100) {
pr_warn("CAIF Interface MTU too small (%d)\n", mtu); pr_warn("CAIF Interface MTU too small (%d)\n", mtu);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment