Commit a7df5c5e authored by Julia Lawall's avatar Julia Lawall Committed by Benjamin Herrenschmidt

powerpc/pseries/dlpar: Eliminate use after free

dlpar_free_cc_nodes frees its argument, so dlpar_online_cpu should not be
called on the same value.  Skip over the call to dlpar_online_cpu by
jumping directly to out.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E,E2;
@@

dlpar_free_cc_nodes(E)
...
(
  E = E2
|
* E
)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent ab30f78c
...@@ -433,6 +433,7 @@ static ssize_t dlpar_cpu_probe(const char *buf, size_t count) ...@@ -433,6 +433,7 @@ static ssize_t dlpar_cpu_probe(const char *buf, size_t count)
if (rc) { if (rc) {
dlpar_release_drc(drc_index); dlpar_release_drc(drc_index);
dlpar_free_cc_nodes(dn); dlpar_free_cc_nodes(dn);
goto out;
} }
rc = dlpar_online_cpu(dn); rc = dlpar_online_cpu(dn);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment