Commit a8779c35 authored by Michał Kępień's avatar Michał Kępień Committed by Darren Hart (VMware)

platform/x86: fujitsu-laptop: simplify set_lcd_level()

acpi_execute_simple_method() takes a method parameter which tells it to
look for the given method underneath the given handle, so calling
acpi_get_handle() beforehand is redundant.  Replace the call to
acpi_get_handle() with a call to acpi_execute_simple_method(), thus
eliminating the need for a local variable storing the handle.  Update
debug message to reflect this change.  Also do not assign a default
value to status as it has no influence on execution flow.
Signed-off-by: default avatarMichał Kępień <kernel@kempniu.pl>
Reviewed-by: default avatarJonathan Woithe <jwoithe@just42.net>
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent e32c50ba
...@@ -343,8 +343,7 @@ static enum led_brightness eco_led_get(struct led_classdev *cdev) ...@@ -343,8 +343,7 @@ static enum led_brightness eco_led_get(struct led_classdev *cdev)
static int set_lcd_level(int level) static int set_lcd_level(int level)
{ {
acpi_status status = AE_OK; acpi_status status;
acpi_handle handle = NULL;
char *method; char *method;
switch (use_alt_lcd_levels) { switch (use_alt_lcd_levels) {
...@@ -362,16 +361,14 @@ static int set_lcd_level(int level) ...@@ -362,16 +361,14 @@ static int set_lcd_level(int level)
if (level < 0 || level >= fujitsu_bl->max_brightness) if (level < 0 || level >= fujitsu_bl->max_brightness)
return -EINVAL; return -EINVAL;
status = acpi_get_handle(fujitsu_bl->acpi_handle, method, &handle); status = acpi_execute_simple_method(fujitsu_bl->acpi_handle, method,
level);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
vdbg_printk(FUJLAPTOP_DBG_ERROR, "%s not present\n", method); vdbg_printk(FUJLAPTOP_DBG_ERROR, "Failed to evaluate %s\n",
method);
return -ENODEV; return -ENODEV;
} }
status = acpi_execute_simple_method(handle, NULL, level);
if (ACPI_FAILURE(status))
return -ENODEV;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment