Commit a8e98f34 authored by Dmitry Fomin's avatar Dmitry Fomin Committed by Takashi Iwai

ALSA: ice1712: Delete unreachable code in aureon_add_controls()

If the check (id != 0x41) fails, then id == 0x41 and
the other check in 'else' branch also
fails: id & 0x0F = 0b01000001 & 0b00001111 = 0b00000001.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarDmitry Fomin <fomindmitriyfoma@mail.ru>
Link: https://lore.kernel.org/r/20230225184322.6286-2-fomindmitriyfoma@mail.ruSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 951606a1
...@@ -1896,10 +1896,6 @@ static int aureon_add_controls(struct snd_ice1712 *ice) ...@@ -1896,10 +1896,6 @@ static int aureon_add_controls(struct snd_ice1712 *ice)
if (id != 0x41) if (id != 0x41)
dev_info(ice->card->dev, dev_info(ice->card->dev,
"No CS8415 chip. Skipping CS8415 controls.\n"); "No CS8415 chip. Skipping CS8415 controls.\n");
else if ((id & 0x0F) != 0x01)
dev_info(ice->card->dev,
"Detected unsupported CS8415 rev. (%c)\n",
(char)((id & 0x0F) + 'A' - 1));
else { else {
for (i = 0; i < ARRAY_SIZE(cs8415_controls); i++) { for (i = 0; i < ARRAY_SIZE(cs8415_controls); i++) {
struct snd_kcontrol *kctl; struct snd_kcontrol *kctl;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment