Commit a9ce3eef authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: cb_pcimdda: use dev->iobase

Use dev->iobase for the pci i/o address instead of carrying it
in the private data.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b41bf58f
...@@ -137,7 +137,6 @@ static const struct cb_pcimdda_board cb_pcimdda_boards[] = { ...@@ -137,7 +137,6 @@ static const struct cb_pcimdda_board cb_pcimdda_boards[] = {
* struct. * struct.
*/ */
struct cb_pcimdda_private { struct cb_pcimdda_private {
unsigned long registers; /* set by probe */
unsigned long dio_registers; unsigned long dio_registers;
char attached_to_8255; /* boolean */ char attached_to_8255; /* boolean */
/* would be useful for a PCI device */ /* would be useful for a PCI device */
...@@ -157,7 +156,7 @@ static int cb_pcimdda_ao_winsn(struct comedi_device *dev, ...@@ -157,7 +156,7 @@ static int cb_pcimdda_ao_winsn(struct comedi_device *dev,
struct cb_pcimdda_private *devpriv = dev->private; struct cb_pcimdda_private *devpriv = dev->private;
int i; int i;
int chan = CR_CHAN(insn->chanspec); int chan = CR_CHAN(insn->chanspec);
unsigned long offset = devpriv->registers + chan * 2; unsigned long offset = dev->iobase + chan * 2;
/* Writing a list of values to an AO channel is probably not /* Writing a list of values to an AO channel is probably not
* very useful, but that's how the interface is defined. */ * very useful, but that's how the interface is defined. */
...@@ -201,7 +200,7 @@ static int cb_pcimdda_ao_rinsn(struct comedi_device *dev, ...@@ -201,7 +200,7 @@ static int cb_pcimdda_ao_rinsn(struct comedi_device *dev,
int chan = CR_CHAN(insn->chanspec); int chan = CR_CHAN(insn->chanspec);
for (i = 0; i < insn->n; i++) { for (i = 0; i < insn->n; i++) {
inw(devpriv->registers + chan * 2); inw(dev->iobase + chan * 2);
/* /*
* should I set data[i] to the result of the actual read * should I set data[i] to the result of the actual read
* on the register or the cached unsigned int in * on the register or the cached unsigned int in
...@@ -263,9 +262,9 @@ static int cb_pcimdda_attach(struct comedi_device *dev, ...@@ -263,9 +262,9 @@ static int cb_pcimdda_attach(struct comedi_device *dev,
err = comedi_pci_enable(pcidev, dev->board_name); err = comedi_pci_enable(pcidev, dev->board_name);
if (err) if (err)
return err; return err;
devpriv->registers = pci_resource_start(devpriv->pci_dev, dev->iobase = pci_resource_start(devpriv->pci_dev,
thisboard->regs_badrindex); thisboard->regs_badrindex);
devpriv->dio_registers = devpriv->registers + thisboard->dio_offset; devpriv->dio_registers = dev->iobase + thisboard->dio_offset;
err = comedi_alloc_subdevices(dev, 2); err = comedi_alloc_subdevices(dev, 2);
if (err) if (err)
...@@ -323,7 +322,7 @@ static void cb_pcimdda_detach(struct comedi_device *dev) ...@@ -323,7 +322,7 @@ static void cb_pcimdda_detach(struct comedi_device *dev)
devpriv->attached_to_8255 = 0; devpriv->attached_to_8255 = 0;
} }
if (devpriv->pci_dev) { if (devpriv->pci_dev) {
if (devpriv->registers) if (dev->iobase)
comedi_pci_disable(devpriv->pci_dev); comedi_pci_disable(devpriv->pci_dev);
pci_dev_put(devpriv->pci_dev); pci_dev_put(devpriv->pci_dev);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment