Commit a9d8723c authored by Amadeusz Sławiński's avatar Amadeusz Sławiński Committed by Mark Brown

ASoC: Intel: avs: rt5682: Refactor jack handling

Use link->exit() rather than pdev->remove() to unassign jack during card
unbind procedure so codec link initialization and exit procedures are
symmetrical.

Also, there is no need to perform search for codec dai in suspend_pre()
and resume_post() ourselves. Use snd_soc_card_get_codec_dai() instead.
Signed-off-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20221129180738.2866290-3-cezary.rojewski@intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 19bb7c30
...@@ -120,6 +120,11 @@ static int avs_rt5682_codec_init(struct snd_soc_pcm_runtime *runtime) ...@@ -120,6 +120,11 @@ static int avs_rt5682_codec_init(struct snd_soc_pcm_runtime *runtime)
return 0; return 0;
}; };
static void avs_rt5682_codec_exit(struct snd_soc_pcm_runtime *rtd)
{
snd_soc_component_set_jack(asoc_rtd_to_codec(rtd, 0)->component, NULL, NULL);
}
static int static int
avs_rt5682_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) avs_rt5682_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params)
{ {
...@@ -195,6 +200,7 @@ static int avs_create_dai_link(struct device *dev, const char *platform_name, in ...@@ -195,6 +200,7 @@ static int avs_create_dai_link(struct device *dev, const char *platform_name, in
dl->num_platforms = 1; dl->num_platforms = 1;
dl->id = 0; dl->id = 0;
dl->init = avs_rt5682_codec_init; dl->init = avs_rt5682_codec_init;
dl->exit = avs_rt5682_codec_exit;
dl->ops = &avs_rt5682_ops; dl->ops = &avs_rt5682_ops;
dl->nonatomic = 1; dl->nonatomic = 1;
dl->no_pcm = 1; dl->no_pcm = 1;
...@@ -238,30 +244,19 @@ static int avs_create_dapm_routes(struct device *dev, int ssp_port, ...@@ -238,30 +244,19 @@ static int avs_create_dapm_routes(struct device *dev, int ssp_port,
return 0; return 0;
} }
static int avs_card_set_jack(struct snd_soc_card *card, struct snd_soc_jack *jack)
{
struct snd_soc_component *component;
for_each_card_components(card, component)
snd_soc_component_set_jack(component, jack, NULL);
return 0;
}
static int avs_card_remove(struct snd_soc_card *card)
{
return avs_card_set_jack(card, NULL);
}
static int avs_card_suspend_pre(struct snd_soc_card *card) static int avs_card_suspend_pre(struct snd_soc_card *card)
{ {
return avs_card_set_jack(card, NULL); struct snd_soc_dai *codec_dai = snd_soc_card_get_codec_dai(card, AVS_RT5682_CODEC_DAI_NAME);
return snd_soc_component_set_jack(codec_dai->component, NULL, NULL);
} }
static int avs_card_resume_post(struct snd_soc_card *card) static int avs_card_resume_post(struct snd_soc_card *card)
{ {
struct snd_soc_dai *codec_dai = snd_soc_card_get_codec_dai(card, AVS_RT5682_CODEC_DAI_NAME);
struct snd_soc_jack *jack = snd_soc_card_get_drvdata(card); struct snd_soc_jack *jack = snd_soc_card_get_drvdata(card);
return avs_card_set_jack(card, jack); return snd_soc_component_set_jack(codec_dai->component, jack, NULL);
} }
static int avs_rt5682_probe(struct platform_device *pdev) static int avs_rt5682_probe(struct platform_device *pdev)
...@@ -305,7 +300,6 @@ static int avs_rt5682_probe(struct platform_device *pdev) ...@@ -305,7 +300,6 @@ static int avs_rt5682_probe(struct platform_device *pdev)
card->name = "avs_rt5682"; card->name = "avs_rt5682";
card->dev = dev; card->dev = dev;
card->owner = THIS_MODULE; card->owner = THIS_MODULE;
card->remove = avs_card_remove;
card->suspend_pre = avs_card_suspend_pre; card->suspend_pre = avs_card_suspend_pre;
card->resume_post = avs_card_resume_post; card->resume_post = avs_card_resume_post;
card->dai_link = dai_link; card->dai_link = dai_link;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment