Commit ab921f3c authored by David Laight's avatar David Laight Committed by David S. Miller

net: sctp: Fix negotiation of the number of data streams.

The number of output and input streams was never being reduced, eg when
processing received INIT or INIT_ACK chunks.
The effect is that DATA chunks can be sent with invalid stream ids
and then discarded by the remote system.

Fixes: 2075e50c ("sctp: convert to genradix")
Signed-off-by: default avatarDavid Laight <david.laight@aculab.com>
Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 41506bff
...@@ -88,12 +88,13 @@ static int sctp_stream_alloc_out(struct sctp_stream *stream, __u16 outcnt, ...@@ -88,12 +88,13 @@ static int sctp_stream_alloc_out(struct sctp_stream *stream, __u16 outcnt,
int ret; int ret;
if (outcnt <= stream->outcnt) if (outcnt <= stream->outcnt)
return 0; goto out;
ret = genradix_prealloc(&stream->out, outcnt, gfp); ret = genradix_prealloc(&stream->out, outcnt, gfp);
if (ret) if (ret)
return ret; return ret;
out:
stream->outcnt = outcnt; stream->outcnt = outcnt;
return 0; return 0;
} }
...@@ -104,12 +105,13 @@ static int sctp_stream_alloc_in(struct sctp_stream *stream, __u16 incnt, ...@@ -104,12 +105,13 @@ static int sctp_stream_alloc_in(struct sctp_stream *stream, __u16 incnt,
int ret; int ret;
if (incnt <= stream->incnt) if (incnt <= stream->incnt)
return 0; goto out;
ret = genradix_prealloc(&stream->in, incnt, gfp); ret = genradix_prealloc(&stream->in, incnt, gfp);
if (ret) if (ret)
return ret; return ret;
out:
stream->incnt = incnt; stream->incnt = incnt;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment