Commit abaa03b0 authored by Sasha Levin's avatar Sasha Levin Committed by Ben Hutchings

power: test_power: correctly handle empty writes

commit 6b9140f3 upstream.

Writing 0 length data into test_power makes it access an invalid array
location and kill the system.

Fixes: f17ef9b2 ("power: Make test_power driver more dynamic.")
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 92d90941
...@@ -237,6 +237,8 @@ static int map_get_value(struct battery_property_map *map, const char *key, ...@@ -237,6 +237,8 @@ static int map_get_value(struct battery_property_map *map, const char *key,
buf[MAX_KEYLENGTH-1] = '\0'; buf[MAX_KEYLENGTH-1] = '\0';
cr = strnlen(buf, MAX_KEYLENGTH) - 1; cr = strnlen(buf, MAX_KEYLENGTH) - 1;
if (cr < 0)
return def_val;
if (buf[cr] == '\n') if (buf[cr] == '\n')
buf[cr] = '\0'; buf[cr] = '\0';
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment